Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2816 : Add label for OptionsActivity #2964

Merged
merged 5 commits into from
Mar 25, 2021

Conversation

starboi02
Copy link
Contributor

Explanation

Fixes #2816 : Add label for OptionsActivity

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@prayutsu prayutsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @starboi02, just suggest a nit change. PTAL.

@prayutsu
Copy link
Contributor

Also, ensure that when your PR is ready for review, just leave a PTAL comment and mention the reviewers, so that they do not miss the PR to review.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@starboi02
Copy link
Contributor Author

@rt4914 @prayutsu PTAL. Made the changes suggested.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 assigned BenHenning and prayutsu and unassigned starboi02 Mar 22, 2021
Copy link
Contributor

@prayutsu prayutsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prayutsu prayutsu removed their assignment Mar 22, 2021
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @starboi02! I have nothing to add--this LGTM!

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though, it appears there's a merge conflict. @starboi02 could you please merge with the latest changes from develop & address the merge conflict?

@BenHenning BenHenning assigned starboi02 and BenHenning and unassigned BenHenning Mar 23, 2021
@starboi02
Copy link
Contributor Author

@BenHenning I have resolved the merge conflict . PTAL.

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @starboi02! LGTM.

@BenHenning BenHenning merged commit 86aa93f into oppia:develop Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[A11y] Add label for OptionsActivity
4 participants