-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2816 : Add label for OptionsActivity #2964
Fix #2816 : Add label for OptionsActivity #2964
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @starboi02, just suggest a nit change. PTAL.
app/src/sharedTest/java/org/oppia/android/app/options/OptionsActivityTest.kt
Outdated
Show resolved
Hide resolved
Also, ensure that when your PR is ready for review, just leave a PTAL comment and mention the reviewers, so that they do not miss the PR to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL
app/src/sharedTest/java/org/oppia/android/app/options/OptionsActivityTest.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/android/app/options/OptionsActivityTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @starboi02! I have nothing to add--this LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though, it appears there's a merge conflict. @starboi02 could you please merge with the latest changes from develop & address the merge conflict?
@BenHenning I have resolved the merge conflict . PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @starboi02! LGTM.
Explanation
Fixes #2816 : Add label for OptionsActivity
Checklist