Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2810: Added label for CompletedStoryListActivity #2949

Merged
merged 3 commits into from
Mar 23, 2021
Merged

Fix #2810: Added label for CompletedStoryListActivity #2949

merged 3 commits into from
Mar 23, 2021

Conversation

ChiragKalra
Copy link
Contributor

@ChiragKalra ChiragKalra commented Mar 19, 2021

Explanation

Fixes #2810

Added label for CompletedStoryListActivity to read "Stories Completed" when talkback is on.

Created a common string resource "completed_story_list_activity_title" for all layouts of this activty.

Added test for CompletedStoryListActivity title.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@anandwana001
Copy link
Contributor

PR title - Fix #2810: Added label for CompletedStoryListActivity

@ChiragKalra ChiragKalra changed the title Fixes #2810: Added label for CompletedStoryListActivity Fix #2810: Added label for CompletedStoryListActivity Mar 22, 2021
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChiragKalra PTAL.

@rt4914 rt4914 removed their assignment Mar 22, 2021
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit change.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 assigned BenHenning and unassigned ChiragKalra Mar 22, 2021
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ChiragKalra! I have no comments to add--this LGTM!

@BenHenning BenHenning merged commit fe5bc07 into oppia:develop Mar 23, 2021
@ChiragKalra ChiragKalra deleted the label-completed-stories branch March 23, 2021 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[A11y] Add label for CompletedStoryListActivity
4 participants