Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2822 : Add label AppVersionActivity #2905

Merged
merged 13 commits into from
Mar 30, 2021
Merged

Fix #2822 : Add label AppVersionActivity #2905

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
306e6ca
added label for appversion activity
E13ctron Mar 14, 2021
f7b5b8c
Corrections in auto generated file and strings.xml
E13ctron Mar 14, 2021
e2e88c6
corrections
E13ctron Mar 14, 2021
e6d994b
corrections
E13ctron Mar 14, 2021
b2f81cc
suggestion change
E13ctron Mar 14, 2021
1bff242
Added test
E13ctron Mar 16, 2021
0acfa72
correction in test
E13ctron Mar 16, 2021
69ee682
Made the suggested changes
E13ctron Mar 23, 2021
da31a59
correction
E13ctron Mar 23, 2021
9110266
Correction for lint test
E13ctron Mar 23, 2021
bdc2373
NIT fix
E13ctron Mar 23, 2021
43876d8
style correction
E13ctron Mar 23, 2021
29bc72c
change of imports
E13ctron Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
android:theme="@style/OppiaThemeWithoutActionBar" />
<activity
android:name=".app.administratorcontrols.appversion.AppVersionActivity"
android:label="@string/app_version_activity_label"
android:theme="@style/OppiaThemeWithoutActionBar" />
<activity
android:name=".app.completedstorylist.CompletedStoryListActivity"
Expand Down
1 change: 1 addition & 0 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,7 @@
<!-- AppVersionFragment -->
<string name="app_version_name">App Version %s</string>
<string name="app_last_update_date">The last update was installed on %s. Use the above version number to send feedback about bugs.</string>
<string name="app_version_activity_label">App Version</string>
E13ctron marked this conversation as resolved.
Show resolved Hide resolved
<!-- OptionsActivity -->
<string name="title_reading_text_size">Reading Text Size</string>
<string name="title_app_language">App Language</string>
Expand Down