Fix #2743: A11y activity labels part 1 #2782
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #2743
This PR introduces labels for different activities which are needed for A11y.
In this PR we have kept
labelsseparate fromtitlethis is because there can be cases where we have different labels and titles for same screen. (Like in FAQ). However this means that we are creating repetitive strings. Do let me know if we choose to merge this?Also, this PR does not create strings for all files.
Not putting the output as it would be a long recording for A11y. So follow below steps for checking this PR.
Also, for
SplashActivityi have usedOppiaas it would be nice to say app name instead ofSplash. And also because we are not providing any output for the logo in this screen, this solution should suffice for that and therefore will not create any redundancy. WDYT?