Fix #2652: Splash Screen stretched

[anshbajpai]

Explanation

This PR fixes #2652 the splash screen, and splash screen doesn't stretch anymore on large screen devices, by adding a new drawable file named splash_image.xml

Mobile Portrait Screenshot

Tablet Portrait Screenshot

Checklist

• The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
• The PR follows the style guide.
• The PR does not contain any unnecessary auto-generated code from Android Studio.
• The PR is made from a branch that's not called "develop".
• The PR is made from a branch that is up-to-date with "develop".
• The PR's branch is based on "develop" and not on any other branch.
• The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

[rt4914]

@anshbajpai Please add images for splash screen in description for following cases:

1. Mobile Portrait
2. Mobile Landscape
3. Tablet Portrait
4. Tablet Landscape

In general any UI change related PR should have screenshots in description.

[rt4914]

This approach is better but the issue is with the image in bigger devices. On bigger devices the image looks small.

[rt4914]

@anshbajpai Update title to Fix #2652: Splash Screen stretched

[anshbajpai]

This approach is better but the issue is with the image in bigger devices. On bigger devices the image looks small.

@rt4914 so does the main logo should look the same like it does on mobile , on bigger devices like tablet . I have updated the current description with both the respective pictures.

[anshbajpai]

@rt4914 I am not sure, why one of the checks has failed , could you help me in understanding it ?

[FareesHussain]

@rt4914 I am not sure, why one of the checks has failed , could you help me in understanding it ?

@anshbajpai Don't worry about it. There are some flaky tests. We just need to re-run the workflow

[rt4914]

@mschanteltc Have a look at the PR description. Can we have mocks for mobile landscape, tablet landscape and tablet portrait to check what should be the exact dimens for the logo.

[mschanteltc]

@mschanteltc Have a look at the PR description. Can we have mocks for mobile landscape, tablet landscape and tablet portrait to check what should be the exact dimens for the logo.

Is it possible to format the logo depending on the device width? I have mocks to show what percentage of the screen width the logo and margins should be.

• Mobile (Portrait, Landscape)
• Tablet (Portrait, Landscape)

[rt4914]

@mschanteltc Have a look at the PR description. Can we have mocks for mobile landscape, tablet landscape and tablet portrait to check what should be the exact dimens for the logo.

Is it possible to format the logo depending on the device width? I have mocks to show what percentage of the screen width the logo and margins should be.

• Mobile (Portrait, Landscape)
• Tablet (Portrait, Landscape)

@mschanteltc Yes it is possible to control margins based on device width but we cannot see the width can you provide the specs link. Also Image 1 and Image 2 have different sit above line UI. Suggest making it similar so that it becomes easier to implement.

[mschanteltc]

@mschanteltc Have a look at the PR description. Can we have mocks for mobile landscape, tablet landscape and tablet portrait to check what should be the exact dimens for the logo.

Is it possible to format the logo depending on the device width? I have mocks to show what percentage of the screen width the logo and margins should be.

• Mobile (Portrait, Landscape)
• Tablet (Portrait, Landscape)

@mschanteltc Yes it is possible to control margins based on device width but we cannot see the width can you provide the specs link. Also Image 1 and Image 2 have different sit above line UI. Suggest making it similar so that it becomes easier to implement.

Updated the links to include the specs. Also fixed the formatting of the logo so they should be the same now (mobile portrait and tablet portrait).

[rt4914]

@mschanteltc Have a look at the PR description. Can we have mocks for mobile landscape, tablet landscape and tablet portrait to check what should be the exact dimens for the logo.

Is it possible to format the logo depending on the device width? I have mocks to show what percentage of the screen width the logo and margins should be.

• Mobile (Portrait, Landscape)
• Tablet (Portrait, Landscape)

@mschanteltc Yes it is possible to control margins based on device width but we cannot see the width can you provide the specs link. Also Image 1 and Image 2 have different sit above line UI. Suggest making it similar so that it becomes easier to implement.

Updated the links to include the specs. Also fixed the formatting of the logo so they should be the same now (mobile portrait and tablet portrait).

@anshbajpai I think you can work on this now.

[FareesHussain]

@anshbajpai Any updates on this?

[FareesHussain]

Closing this as there is no update from @anshbajpai