Fix part of #1833: Prepare to rename package to org.oppia.android (part 1/2) #1879
Conversation
This moves all Kotlin source files to be under an org.oppia.android structure, but does not actually change references. This is done in two steps to try and preserve history, and to simplify the code review. THIS WILL BREAK THE CODEBASE WHEN CHECKED IN.
|
@rt4914 @anandwana001 PTAL. Note that checks will fail for this, which means that the PR will need to be force merged. |
There was a problem hiding this comment.
LGTM, thanks @BenHenning
Just concern with two points:
- What about the model package
|
@anandwana001 there are no directory structure changes needed in model. The actual package references should be updated in #1876 (see example.proto in that PR--I can't link to it since the PR is so large). Does this address your question? |
Yes, I got it. |
|
Thanks. NB: The Gradle tests are passing due to Gradle not actually enforcing that file packages match their directory structure. Bazel is stricter, so it's breaking as expected. |
|
@rt4914 I will block submission on your review. |
|
Thanks! I will submit this only after #1876 is approved. |
|
Email is ready to go out, and will be sent immediately after merging. I have updated branch protections to require all PRs are up-to-date with develop, thereby preventing people from submitting changes after this PR goes in (since it breaks the Bazel check). This isn't a super robust way to stop changes, but it should well enough for the next ~30 minutes. Force merging this PR despite failing checks. Checks will be passing again in #1876. |
BenHenning
deleted the
move-files-to-prepare-for-new-app-package-structure
branch
BenHenning
added
the
PR: Cherrypick requested
This moves all Kotlin source files to be under an org.oppia.android structure, but does not actually change references. This is done in two steps to try and preserve history, and to simplify the code review. THIS WILL BREAK THE CODEBASE WHEN CHECKED IN.
BenHenning
added
the
PR: Cherrypick completed
This moves all Kotlin source files to be under an org.oppia.android structure, but does not actually change references. This is done in two steps to try and preserve history, and to simplify the code review. THIS WILL BREAK THE CODEBASE WHEN CHECKED IN.
Fixes part of #1833.
This moves all Kotlin source files to be under an org.oppia.android structure, but does not actually change references. This is done in two steps to try and preserve history, and to simplify the code reviews.
THIS WILL BREAK THE CODEBASE WHEN CHECKED IN. I'll be sending out an email shortly explaining the situation to oppia-android-dev@.
#1876 (or a similar PR) will follow up with the actual import changes to fix everything.