Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging system #8

Closed
BenHenning opened this issue Aug 2, 2019 · 9 comments
Closed

Logging system #8

BenHenning opened this issue Aug 2, 2019 · 9 comments
Assignees
Labels
Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

There should be an easy-to-use (preferable via fluent pattern) logging system on top of logcat that will be used throughout the app. This should log to a local file specific for the app so that app-level logs can be uploaded with user feedback reports. It's highly preferable to use an existing logging API if one is available rather than building this from scratch.

@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Aug 2, 2019
@BenHenning BenHenning added this to the Proof of concept milestone Aug 2, 2019
@BenHenning
Copy link
Member Author

This is blocked on #4.

This was referenced Aug 2, 2019
@BenHenning
Copy link
Member Author

NB: Logs also need to be retrievable (e.g. for user feedback reporting & for displaying in the developer menu).

Although not explicitly blocking, all downstream work will likely introduce logs using this system so it should be implemented as early in the project as possible.

@BenHenning BenHenning changed the title Logging system Logging system [Blocked: #4] Aug 12, 2019
@BenHenning
Copy link
Member Author

@veena14cs can you document your findings here about why you chose the logging solution that you did? Also, note that one requirement in this issue is to find a fluent logger (https://dzone.com/articles/fluent-builder-pattern). Flogger (https://google.github.io/flogger/) is one such example, but I believe it's not compatible with Android (this may require further investigation on your part if Flogger looks promising for us).

@veena14cs
Copy link
Contributor

veena14cs commented Aug 22, 2019 via email

@BenHenning
Copy link
Member Author

BenHenning commented Aug 23, 2019

What do you mean by specific logs? I'm not sure that I understand. Can you provide an example?

@veena14cs
Copy link
Contributor

veena14cs commented Aug 23, 2019 via email

@BenHenning
Copy link
Member Author

@veena14cs per our meeting last week, what's your proposed solution for logging? Please document your thoughts in this issue.

@BenHenning
Copy link
Member Author

Pushing this back to the prototype milestone. We can live with Android's Log class in the meantime.

@BenHenning BenHenning modified the milestones: Proof of concept, Prototype Sep 1, 2019
@BenHenning BenHenning added Priority: Nice-to-have This work item is nice to have for its milestone. and removed Priority: Essential This work item must be completed for its milestone. labels Sep 1, 2019
@BenHenning
Copy link
Member Author

Similarly, we can probably live without this until MVP or GA when deeper investigations become more important.

@BenHenning BenHenning changed the title Logging system [Blocked: #4] Logging system Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

No branches or pull requests

2 participants