-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging system #8
Comments
This is blocked on #4. |
NB: Logs also need to be retrievable (e.g. for user feedback reporting & for displaying in the developer menu). Although not explicitly blocking, all downstream work will likely introduce logs using this system so it should be implemented as early in the project as possible. |
@veena14cs can you document your findings here about why you chose the logging solution that you did? Also, note that one requirement in this issue is to find a fluent logger (https://dzone.com/articles/fluent-builder-pattern). Flogger (https://google.github.io/flogger/) is one such example, but I believe it's not compatible with Android (this may require further investigation on your part if Flogger looks promising for us). |
I am going through flogger. I will let you know about it once I get enough
information.
And also I want to know that whether we need to have only specific logs?
…On Wed, Aug 21, 2019 at 11:54 PM Ben Henning ***@***.***> wrote:
@veena14cs <https://github.com/veena14cs> can you document your findings
here about why you chose the logging solution that you did? Also, note that
one requirement in this issue is to find a fluent logger (
https://dzone.com/articles/fluent-builder-pattern). Flogger (
https://google.github.io/flogger/) is one such example, but I believe
it's not compatible with Android (this may require further investigation on
your part if Flogger looks promising for us).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8?email_source=notifications&email_token=AD4LXZFYRP25XCUWTWTWXUDQFYZYPA5CNFSM4II2NTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD44CWOY#issuecomment-523774779>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AD4LXZE7NUYQ4Z7YZ4NHHIDQFYZYPANCNFSM4II2NTFA>
.
|
What do you mean by specific logs? I'm not sure that I understand. Can you provide an example? |
I mean to say messages that we add to the app with the Log
<https://developer.android.com/reference/android/util/Log.html> class.
…On Thu, Aug 22, 2019 at 6:39 PM Ben Henning ***@***.***> wrote:
What do you mean by specific logs? I'm not sure that I understand.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8?email_source=notifications&email_token=AD4LXZFLOR7WQELGIBUX6X3QF45WDA5CNFSM4II2NTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD463U7A#issuecomment-524139132>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AD4LXZF7GG5X5ANH4FENTOTQF45WDANCNFSM4II2NTFA>
.
|
@veena14cs per our meeting last week, what's your proposed solution for logging? Please document your thoughts in this issue. |
Pushing this back to the prototype milestone. We can live with Android's Log class in the meantime. |
Similarly, we can probably live without this until MVP or GA when deeper investigations become more important. |
There should be an easy-to-use (preferable via fluent pattern) logging system on top of logcat that will be used throughout the app. This should log to a local file specific for the app so that app-level logs can be uploaded with user feedback reports. It's highly preferable to use an existing logging API if one is available rather than building this from scratch.
The text was updated successfully, but these errors were encountered: