Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lowfi Landscape: ContinuePlaying Screen #666

Closed
2 tasks
rt4914 opened this issue Feb 16, 2020 · 2 comments · Fixed by #673
Closed
2 tasks

Lowfi Landscape: ContinuePlaying Screen #666

rt4914 opened this issue Feb 16, 2020 · 2 comments · Fixed by #673
Assignees
@rt4914
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Feb 16, 2020

Mock: https://xd.adobe.com/view/ee9e607b-dbd6-4372-48dc-b687d32af3da-98af/screen/0e6ba726-1930-4f39-9c73-51df10a1c766/HP-Continue-Playing-

Portrait Mock: https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/2b6c8e95-5ac7-4472-bc2b-1c318a3f7e5c/HP-Continue-Playing-

Note that we are currently not focusing on "Download" information on top right corner. So do not create UI for that.

Checklist

  • Landscape Layout
  • Test cases
@rt4914 rt4914 self-assigned this Feb 16, 2020
@rt4914
Copy link
Contributor Author

rt4914 commented Feb 16, 2020

Assigning this to @abhinavraj23

@abhinavraj23 abhinavraj23 mentioned this issue Feb 20, 2020
Merged
8 tasks
@abhinavraj23
Copy link
Contributor

@rt4914 I have made the PR, I have tested it as well, it is working, please review it and let me know!

rt4914 pushed a commit that referenced this issue Feb 20, 2020
@abhinavraj23
Fix #666: Lowfi Landscape: ContinuePlaying Screen (#673)
a01be8c 
* Added landscape layout to ContinuePlaying Screen

* Added tests for landscape layout
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #666: Lowfi Landscape: ContinuePlaying Screen abhinavraj23/oppia-android
3 participants
@rt4914 @BenHenning @abhinavraj23