Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Low-fi : Introduce Subtopic System #646

Closed
veena14cs opened this issue Feb 12, 2020 · 1 comment
Closed

Low-fi : Introduce Subtopic System #646

veena14cs opened this issue Feb 12, 2020 · 1 comment
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@veena14cs
Copy link
Contributor

Need to introduce Subtopic system in domain and app layer module. This include changes in Revision and Practice Tab.
rt4914 pushed a commit that referenced this issue Feb 14, 2020
@veena14cs
Fix part #646: Low-fi Introduce Subtopic System in Domain Layer (#647)
3925725 
* add subtopic in domain

* Update TopicController.kt

* update proto

* Update TopicController.kt

* updated nit change

* Update TopicControllerTest.kt

* Update topic.proto

* Update topic.proto

* fixed nit
veena14cs added a commit that referenced this issue Feb 25, 2020
@veena14cs
Fix part #646: Low-fi Introduce Subtopic in Revision Mode (#648)
2d21c6d 
* add subtopic in domain

* Update TopicController.kt

* update

* update proto

* add layout files

* add review card.

* Update TopicController.kt

* update kdoc

* Added testcases

* updated nit change

* Update TopicControllerTest.kt

* Update topic.proto

* Update topic.proto

* Update TopicReviewFragmentPresenter.kt

* fixed issues.

* removed concept card

* fixed issues

* Added test activity

* fixed issues

* fixed tests

* fixed  nit
veena14cs added a commit that referenced this issue Feb 25, 2020
@veena14cs
Fix part #646: Low-fi Introduce Subtopic in Practice Mode (#649)
08235de 
* add subtopic in domain

* Update TopicController.kt

* update proto

* add subtopic in practice tab

* Update TopicController.kt

* Update TopicPracticeFragmentTest.kt

* updated nit change

* Update TopicControllerTest.kt

* Update topic.proto

* Update topic.proto

* working on test cases

* updated practice

* fixed removal of skill ids from selected list

* Update TopicPracticeFragmentTest.kt

* Update TopicPracticeFragmentTest.kt

* fixed nit
@veena14cs
Copy link
Contributor Author

This is fixed in PR #647 , #648 and #649.

@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BenHenning @veena14cs