Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstraction on top of Oppia GAE #5

Closed
2 of 6 tasks
BenHenning opened this issue Aug 2, 2019 · 3 comments
Closed
2 of 6 tasks

Abstraction on top of Oppia GAE #5

BenHenning opened this issue Aug 2, 2019 · 3 comments
Assignees
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

BenHenning commented Aug 2, 2019

The Oppia GAE backend needs to have an abstraction from which the rest of the app can interact. Since the prototype and MVPs are not expected to support push notifications, this interface will be entirely RESTful with async/future responses with error handling support. This implementation should support RPC retry for appropriate 5xx errors.

Work items:

  • Identify among all existing GAE endpoints (get/post), which we can use during the prototype
  • Loosely identify data missing from the above endpoints (this bucket is expected to be small/non-existent), and identify which endpoints have data which needs to be changed for the Android app
  • Specify the Retrofit interfaces to represent all of the identified endpoints (simple interfaces/no annotations or return types needed beyond pseudocode)
  • Identify what data (via pseudocode data structures/YAML/JSON/etc) we will be passing along from the backend through these endpoints
  • Identify how error handling will work (e.g. what Retrofit does), whether RPC retry is supported & how it is/can be configured, etc.
  • Determine the testing strategy for the GAE endpoints for downstream app components
@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Aug 2, 2019
@BenHenning BenHenning added this to the Proof of concept milestone Aug 2, 2019
@BenHenning
Copy link
Member Author

@BenHenning
Copy link
Member Author

This is blocked on #4 for implementation.

@BenHenning BenHenning changed the title Abstraction on top of Oppia GAE Abstraction on top of Oppia GAE [Blocked on #4] Aug 12, 2019
@BenHenning BenHenning changed the title Abstraction on top of Oppia GAE [Blocked on #4] Abstraction on top of Oppia GAE [Blocked: #4] Aug 12, 2019
@BenHenning BenHenning changed the title Abstraction on top of Oppia GAE [Blocked: #4] Abstraction on top of Oppia GAE [Blocked: #4, #88] Sep 1, 2019
@BenHenning
Copy link
Member Author

I split out the Retrofit bits to #88, so this is now blocked on that. #88 is targeting proof-of-concept and the rest of this really should be part of prototype.

@BenHenning BenHenning removed this from the Proof of concept milestone Sep 1, 2019
@BenHenning BenHenning added this to the Prototype milestone Sep 1, 2019
@BenHenning BenHenning changed the title Abstraction on top of Oppia GAE [Blocked: #4, #88] Abstraction on top of Oppia GAE [Blocked: ##88] Sep 5, 2019
@BenHenning BenHenning changed the title Abstraction on top of Oppia GAE [Blocked: ##88] Abstraction on top of Oppia GAE [Blocked: #88] Sep 5, 2019
@rt4914 rt4914 closed this as completed in 689e970 Sep 10, 2019
rt4914 added a commit that referenced this issue Sep 13, 2019
…r (Part 2) (#99)

* Classroom testcases and exploration service, models and testcases and fake json responses

* Load json files for test cases

* Remove unused imports
@BenHenning BenHenning changed the title Abstraction on top of Oppia GAE [Blocked: #88] Abstraction on top of Oppia GAE Sep 17, 2019
rt4914 added a commit that referenced this issue Sep 17, 2019
#66] (#107)

* StortPage service, models and test-case

* Javadoc update in MockServices
rt4914 added a commit that referenced this issue Sep 17, 2019
…nt System [Blocked: #78] (#102)

* Subtopic service, model and testcases

* Reformatting code

* Nit changes
rt4914 added a commit that referenced this issue Sep 18, 2019
…ked: #66] (#126)

* Concept card service, models and tests

* Linking models to oppia-web

* Nullable data in models
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

No branches or pull requests

2 participants