In Terms of Service the website should be displayed as link and should be clickable

[KolliAnitha]

Describe the bug
In Terms of Service the website should be displayed as link and should be clickable

To Reproduce
Steps to reproduce the behavior:

1. Go to Menu - Help
2. Click on Terms of Service
3. In the 1st paragraph look at the website link

Expected behavior
The link https://www.oppia.org should be displayed as a link and it should be clickable.
The sentence ' Thanks for your interest in Oppia Foundation Inc., a nonprofit that operates the website located at https://www.oppia.org (the Website).'

Website is mentioned twice in the statement.

Demonstration
If applicable, add screenshots or videos to help explain your problem.

Environment
Device/emulator being used: Infinix smart 5A
Android or SDK version (e.g. Android 5 or SDK 21): Android version 11
App version (you can get this through system app settings or via the admin controls menu in-app): 0.10-beta-5e64fae55e

[BenHenning]

This seems like a reasonable thing to fix with auto links.

[SidharthMudgil]

Can you assign this task to me?

[seanlip]

@SidharthMudgil Please follow the instructions here for claiming an issue. You will need to provide an explanation of how you would fix it, and (if possible) a demo of the working fix.

I would also recommend reading and following the other instructions on that page if you haven't already done so. Thanks!

[SidharthMudgil]

Hi @BenHenning, Can I work on this issue?

Solution

Surrounding the link in a tag in the line 7 of app/src/main/res/values/terms_of_service.xml solve the issue.

Old Code

operates the website located at https://www.oppia.org (the "Website"). The

New Code

operates the website located at <a href="https://www.oppia.org">https://www.oppia.org</a> (the "Website"). The

Output

solution.mp4

[BenHenning]

@SidharthMudgil this wasn't mentioned earlier, but the solution needs to be done without changing the XML files for the content (since we'll eventually be generating it based on the versions stored in https://github.com/oppia/oppia). This should be solvable without changing the XML.

[SidharthMudgil]

Hi, @BenHenning I solved the issue by adding these 2 lines in app/src/main/res/layout/policies_fragment.xml

android:linksClickable="true"
android:autoLink="web"

Output

Screenrecorder-2023-02-17-12-56-13-970.mp4

[MohitGupta121]

@BenHenning as we see @pratyaksh1610 is make PR #4771 which is now Stale due to inactivity.
So can we assign this issue to @SidharthMudgil as per his solution #4760 (comment) ?

[MohitGupta121]

@SidharthMudgil I think make PR for this directly if it's looks good then reviewers will automatically merge it.
What do you think @BenHenning @seanlip ?

[seanlip]

Yup, it's fine to make a PR any time if there aren't any existing viable PRs for a given issue (and you can assign the contributor to the issue if you agree with the proposed solution approach).

[MohitGupta121]

Okay sure @seanlip Thanks for your reply.
@SidharthMudgil please go ahead and feel free to make PR for this issue that approach you mentioned. And if you have any query then feel free to comment in the issue thread or PR thread. Thanks.

[SidharthMudgil]

Hi @BenHenning @MohitGupta121, Adding the autolink make the URL clickable but overrides the setMovementMethod property. Hence, other links like <a href="https://www.google.com">here</a> no longer work, same as if we remove the autolink the HTML links will work but the URL no longer will work. The only possible solution I can think of is to wrap all the URLs we want to make clickable around the a tag in all versions stored in https://github.com/oppia/oppia

[BenHenning]

@SidharthMudgil you may need to look at how Android's TextView handles the attribute. We manually set the movement method today, so I suspect we can use something like HtmlCompat linkify programmatically to get the links to have correct URLSpans.

[SidharthMudgil]

@BenHenning How about this solution? https://stackoverflow.com/a/34793313/16177121

[BenHenning]

@BenHenning How about this solution? https://stackoverflow.com/a/34793313/16177121

@SidharthMudgil I think that approach makes sense and is in-line with what I was thinking (though as a nit we should use LinkifyCompat rather than Linkify).

[shakivhussain]

@BenHenning As per your suggestion,
I have resolved this issue without changing XML files.

Please check my PR #4917

[BenHenning]

@shakivhussain this issue is currently assigned to @Uticodes.

[adhiamboperes]

Note to developers: Please see #4918 and comments for the proposed solution to this issue.

[theMr17]

@Tejas-67 Please explain how you plan to solve the issue, so that the issue can be assigned to you. As per your comment.

[Tejas-67]

Hey @theMr17, this issue can be solved using the SpannableStringBuilder object.

[adhiamboperes]

@Tejas-67, in #4918, we were trying to use LinkifyCompat to solve this. Could you tell me why SpannableStringBuilder is better, or put up a draft pr with demo video to demonstrate your solution.

[Tejas-67]

@adhiamboperes SpannableStringBuilder should be preferred because we can have the flexibility to decide what happens when the link is clicked, not just opening a link. Plus, it's easier to change the appearance of the link (colors, textStyles). Also SpannableStringBuilder is faster and more efficient because it won't scan the whole string ( we can simply pass a span range i.e. start index to end index)

[Tejas-67]

@adhiamboperes I am facing an error
"unmappable character (0x90) for encoding windows-1252

• Corresponds to the Arabic (اَلْعَرَب�?يَّة�?‎) macro language. IETF BCP 47 language tag: ar." . Can you please guide me on how to fix this?