Doesn't have dark mode mock for promoted story cards #4600
Assignees
Comments
6 tasks
|
This can be solved in a bit different way. Although we don't have mocks for the promoted cards item but we can still implement the dark-mode designs based on how it has been implemented in other screens. Promoted Story Cards - Light Mode designs are similar to that of Stories Completed or Recently Played. In these cases all of these are stories (not topics) and there designs are somewhat similar. Also, we do have designs for Completed Stories - Dark Mode and Recently Played Stories Therefore by using the theme of above two dark-mode screens we can implement Promoted Stories too. |
|
Okay we take reference from these mockup to solve this issue. Thanks You @rt4914 |
rt4914
pushed a commit
that referenced
this issue
Dec 18, 2022
…Played Screen, Promotional Cards, Profile Progress, Ongoing Topic List, Completed Story List (#4786) <!-- READ ME FIRST: Please fill in the explanation section below and check off every point from the Essential Checklist! --> ## Explanation Dark mode implementation - Home Screen, Recently Played Screen, Promotional Cards, Profile Progress, Ongoing Topic List, Completed Story List Fixes #3122 : Dark theme make colors of the images distorted Fixes #4600 : Doesn't have dark mode mock for promoted story #cards <!-- - Explain what your PR does. If this PR fixes an existing bug, please include - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the issue - when this PR is merged. --> ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [ ] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only ### Home Screen <img src="https://user-images.githubusercontent.com/76530270/206965591-d5217df2-1b1b-4498-85b1-e11ba6e09937.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/206967336-8d2ffdaa-9e69-4295-ba65-1a456996a702.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/206965809-ef4356c1-a1d6-4d51-911b-091f852d307e.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/206967387-181e9699-1566-440a-9285-04a6eda290fe.png" height="400" style="max-width: 100%"> ### Recently Played Screen <img src="https://user-images.githubusercontent.com/76530270/206967520-e0f18ebc-07b2-4600-9a7d-36147169875b.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/206966202-acec138c-8643-49e1-8575-507c908f3549.png" height="400" style="max-width: 100%"> ### Promotional Screen <img src="https://user-images.githubusercontent.com/76530270/206966449-d97d08bf-ee5b-4573-8fea-3aaa89c20f5f.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/206966453-c5e2aac1-63e5-4712-bf6b-975005562d29.png" height="400" style="max-width: 100%"> ### Profile Progress <img src="https://user-images.githubusercontent.com/76530270/206966719-bb8966aa-8725-4858-8d0e-2517719767a3.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/206966713-884f8ea3-906a-4567-bb24-0e8b3d02c48c.png" height="400" style="max-width: 100%"> ### Ongoing Topic List <img src="https://user-images.githubusercontent.com/76530270/206966945-f7eea645-33bb-44ed-9c58-828203b66ddf.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/206966952-05de5e15-aacb-429d-b9eb-c20d68de4cd6.png" height="400" style="max-width: 100%"> ### Completed Story List <img src="https://user-images.githubusercontent.com/76530270/206967156-a84ea164-9090-4405-8376-255d82094a78.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/206967147-a2583718-e2f8-4695-bcf7-31070bc69ded.png" height="400" style="max-width: 100%"> <!-- Delete these section if this PR does not include UI-related changes. --> If your PR includes UI-related changes, then: - Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes - For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see [RTL guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines)) - Add a video showing the full UX flow with a screen reader enabled (see [accessibility guide](https://github.com/oppia/oppia-android/wiki/Accessibility-(A11y)-Guide)) - Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing
Repository owner
moved this from Todo
to Done
in [Task Force] Dark Mode - Android
Dec 18, 2022
BenHenning
moved this to Todo
in [Team] Core Learner and Mastery flows & UI Frontend - Android
BenHenning
moved this from Todo
to Done
in [Team] Core Learner and Mastery flows & UI Frontend - Android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Need to add dark mode mock for
Promoted Story Cards.To reproduce
Once logged in, home activity comes under view and promoted story cards.
The text was updated successfully, but these errors were encountered: