Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListItemLeadingMarginSpanTest is broken when built with Espresso #4546

Closed
BenHenning opened this issue Aug 30, 2022 · 1 comment · Fixed by #4552
Closed

ListItemLeadingMarginSpanTest is broken when built with Espresso #4546

BenHenning opened this issue Aug 30, 2022 · 1 comment · Fixed by #4552
Assignees
@veena14cs
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

Originally found by @KevinGitonga.

ListItemLeadingMarginSpanTest breaks when built on Espresso since it's referencing Robolectric shadows. We need to update it to either work without shadows, or move the tests which require shadows to a ListItemLeadingMarginSpanLocalTest that's not under sharedTest.
@BenHenning
Copy link
Member Author

@veena14cs can you PTAL at this since it is a breakage that was introduced as part of the TOS PR? Also, have you verified all of the sharedTests that were changed via Espresso to make sure they still work correctly?

@veena14cs veena14cs mentioned this issue Sep 3, 2022
Merged
6 tasks
BenHenning pushed a commit that referenced this issue Sep 5, 2022
@veena14cs
Fix #4546: ListItemLeadingMarginSpanTest moved to shared test (#4552)
a7a8c33 
* Update selection_interaction_item.xml

* Update selection_interaction_item.xml

* Update return_to_topic_button_item.xml

* Update return_to_topic_button_item.xml

* Update image_region_selection_interaction_item.xml

* Update image_region_selection_interaction_item.xml

* Update ListItemLeadingMarginSpanTest.kt
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veena14cs veena14cs

Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #4546: ListItemLeadingMarginSpanTest moved to shared test veena14cs/oppia-android
2 participants
@BenHenning @veena14cs