Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full UI: ProfileSelectionFragment/Activity [Blocked: #11, #16, #168] #44

Closed
12 tasks
BenHenning opened this issue Aug 2, 2019 · 11 comments
Closed
12 tasks

Full UI: ProfileSelectionFragment/Activity [Blocked: #11, #16, #168] #44

BenHenning opened this issue Aug 2, 2019 · 11 comments
Assignees
@rt4914
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.4 Release Block...

Comments

@BenHenning
Copy link
Member

BenHenning commented Aug 2, 2019 •
edited by nikitamarysolomanpvt
Loading

The profile selection page may require a lot of custom UI that's not broadly available in the Google material design component libraries. See the PRD for specifics.

Work Items:

Auth Screen

Add Profile Screen

Profile Chooser
@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Aug 2, 2019
@BenHenning BenHenning added this to the Prototype milestone Aug 2, 2019
@BenHenning
Copy link
Member Author

This is blocked on #4, #11, and #16.

This was referenced Aug 2, 2019
Closed
Closed
Closed
Open
@BenHenning BenHenning changed the title Profile selection page Profile selection page [Blocked: #4, #11, #16] Aug 12, 2019
@BenHenning BenHenning changed the title Profile selection page [Blocked: #4, #11, #16] Profile selection page [Blocked: #11, #16] Sep 5, 2019
@BenHenning BenHenning added Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. and removed Priority: Essential This work item must be completed for its milestone. labels Sep 9, 2019
@BenHenning BenHenning changed the title Profile selection page [Blocked: #11, #16] Full UI: ProfileSelectionFragment/Activity [Blocked: #11, #16] Sep 20, 2019
@BenHenning BenHenning mentioned this issue Sep 20, 2019
Closed
@BenHenning BenHenning changed the title Full UI: ProfileSelectionFragment/Activity [Blocked: #11, #16] Full UI: ProfileSelectionFragment/Activity [Blocked: #11, #16, #168] Sep 20, 2019
@BenHenning
Copy link
Member Author

This is also blocked on #168.

@jamesxu0 jamesxu0 self-assigned this Oct 22, 2019
@rt4914
Copy link
Contributor

rt4914 commented Nov 8, 2019

@jamesxu0 Can you please mention all the links in here, which will be part of profile-selection, so that I can divide the High-fi work in that.

@jamesxu0
Copy link
Contributor

@rt4914 What links are you referring to?

@jamesxu0 jamesxu0 mentioned this issue Nov 11, 2019
Merged
8 tasks
@rt4914
Copy link
Contributor

rt4914 commented Nov 11, 2019

@rt4914 What links are you referring to?

@jamesxu0 from mocks, what all links you have used to create ProfileSelection, I want all those links so that I can divide the High-fi issues accordingly.

@BenHenning BenHenning mentioned this issue Nov 30, 2019
Closed
29 tasks
jamesxu0 added a commit that referenced this issue Dec 5, 2019
@jamesxu0
Fixes part of #16 and #44: Implementation of ProfileChooserFragment (#…
04391ef 
…326)

* implemented get and delete

* Finished test cases

* added observing cachestore

* Fixed test cases

* Finished first draft of implementation

* Added additional checks to setCurrentProfileId

* Added more test cases

* Finished test stubs

* Finished test cases

* Added query string to gravatar

* primed cache on init

* Fixed typo

* Fixed addProfile test case

* added create method to PersistentCacheStore

* added setTimestamp and setAdmin

* changed isAdmin to default to false

* Added update last logged in

* Started working on chooser

* debugging

* Added UI for chooser

* added click functionality

* Minor fixes

* Updated to use deferred value from persistentCacheStore

* Updated to use login

* Ensured result is error to post error value

* name can only be letters and unique check now case insensitive

* Added profile sorting by last accessed

* Fixed margins and added gradient

* allow names to have spaces

* Added image rotation and compression

* fixed api requires for exifinterface

* Changed gradle dependency

* Added new asset and changed colors

* Sorted alphabetically

* added local default to tolowercase

* started profile test helper

* Removed broken test, couldn't get mockito to work

* Added ProfileTestHelperTest

* added test case for profilechooserfragment

* using string.xml values in tests

* Minor fixes and added default profile avatar

* minor fixes

* added endline

* Minor fixes.

* Started updating to DataProviders

* Fixed loginToProfile

* Minor fixes

* Added comments and new test.

* minor fixes

* Fixed bug

* Added vector version of avatar

* Minor fixes.

* Converted livedata to dataproviders

* Minor fixes

* Removed coroutines from test.

* Removed ExperimentalCoroutinesApi

* Removed import

* Removed ExperimentalCouroutinesApi

* Fixed failing test cases

* Updated xml to multiples of 4

* Added annotations.

* Fixed test

* Fixed splash activity test

* Fixed ProfileTestHelper
@rt4914 rt4914 mentioned this issue Dec 7, 2019
Closed
8 tasks
@nikitamarysolomanpvt
Copy link
Contributor

@mschanteltc Please do update on this when Add Profiles screen updated design is ready.

@mschanteltc
Copy link

@mschanteltc Please do update on this when Add Profiles screen updated design is ready.

I updated the mocks but on the v7 prototype. The features are also described in the PRD.

nikitamarysolomanpvt added a commit that referenced this issue Jan 8, 2020
@nikitamarysolomanpvt
Fix part of #44: Hi-fi UI admin auth screen in add profile (#585)
6ff860b 
* Admin Auth hi-fi
veena14cs added a commit that referenced this issue Feb 5, 2020
@veena14cs
Fix part #44: Full UI profile pin/password screen. (#597)
38a6a90 
* done ui corrections

* fixed issues.

* Update pin_password_activity.xml

* updated color

* updated icon

* updated pinview shadow

* updated icon color

* changed shadow

* updated mock color

* fix

* Update pin_password_activity.xml

* updated nit change.

* Update pin_password_activity.xml

* removed fixed width

* fixed dimen file changes

* Update dimens.xml
PrarabdhGarg pushed a commit to PrarabdhGarg/oppia-android that referenced this issue Feb 12, 2020
@veena14cs @PrarabdhGarg
Fix part oppia#44: Full UI profile pin/password screen. (oppia#597)
efd93c9 
* done ui corrections

* fixed issues.

* Update pin_password_activity.xml

* updated color

* updated icon

* updated pinview shadow

* updated icon color

* changed shadow

* updated mock color

* fix

* Update pin_password_activity.xml

* updated nit change.

* Update pin_password_activity.xml

* removed fixed width

* fixed dimen file changes

* Update dimens.xml
rt4914 pushed a commit that referenced this issue Feb 13, 2020
@PrarabdhGarg @Luffy18346 @veena14cs
Fix #590: Full UI Switch Profile Option (#651)
018f06f 
* Fix #572: Keyboard visible by default in Admin Pin (#573)

* By default keyboard visibility issue in Admin Pin is resolved

* Created a test case to check about Keyboard visibility by default in Admin Pin.

* Test is modified with the suggested changes

* Fix #577:  Display profile name on navigation drawer. (#578)

* display profile name in navigation drawer

* Updated code implementation

* adding tests

* added testcases

* Update NavigationDrawerFragmentPresenter.kt

* updated nit changes.

* Fix part #44: Full UI profile pin/password screen. (#597)

* done ui corrections

* fixed issues.

* Update pin_password_activity.xml

* updated color

* updated icon

* updated pinview shadow

* updated icon color

* changed shadow

* updated mock color

* fix

* Update pin_password_activity.xml

* updated nit change.

* Update pin_password_activity.xml

* removed fixed width

* fixed dimen file changes

* Update dimens.xml

* Fix part #632: Replace current recyclerview implementation with BindableAdapter usage. (#641)

* working on topic practice.

* reverted

* updated implementation

* Update ContinuePlayingFragmentPresenter.kt

* Update ContinuePlayingFragmentPresenter.kt

* Update ContinuePlayingItemViewModel.kt

* Delete OngoingListAdapter.kt

* nit change

* Update ContinuePlayViewModel.kt

* fixed nit

* Add UI and finctionality for Switch Profile

* Add UI Tests for switch profile option in navigation drawer

* Add UI Tests for switch profile option in navigation drawer

* Minor styling changes

Co-authored-by: Akash Koradia <[email protected]>
Co-authored-by: Veena <[email protected]>
@BenHenning BenHenning added Priority: Essential This work item must be completed for its milestone. and removed Workstream: Finalize Prototype pt2 (20-30 Nov) Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. labels Jun 23, 2020
@BenHenning
Copy link
Member Author

What work is left here @rt4914?

@BenHenning BenHenning assigned rt4914 and unassigned jamesxu0 Jul 8, 2020
@rt4914
Copy link
Contributor

rt4914 commented Jul 22, 2020

Just checked again, this issue has been finished way back via different sub issues. So closing this now.

@rt4914 rt4914 closed this as completed Jul 22, 2020
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.4 Release Blockers (Alpha MR1)
Development

No branches or pull requests
5 participants
@rt4914 @BenHenning @mschanteltc @jamesxu0 @nikitamarysolomanpvt