Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On trying to change admin password, it is asking to uninstall and reinstall the app. Even after doing it unable to change the pin #4366

Closed
KolliAnitha opened this issue May 18, 2022 · 1 comment · Fixed by #4418
Closed

On trying to change admin password, it is asking to uninstall and reinstall the app. Even after doing it unable to change the pin #4366

KolliAnitha opened this issue May 18, 2022 · 1 comment · Fixed by #4418
Assignees
@BenHenning
Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.9 Release Block...

Comments

@KolliAnitha
Copy link

KolliAnitha commented May 18, 2022 •
edited
Loading

Describe the bug
On trying to change admin password, it is asking to uninstall and reinstall the app

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Profile selection page'
  2. Click on 'Admin'
  3. In the Enter PIN dialog box click on I forgot my pin link
  4. Uninstall and Install the app
  5. The PIN is not changed

Expected behavior
Admin should be able to change the PIN

22-05-18-14-47-39.mp4

Environment:
Device name: One plus Nord2 5G
Android version : Android 11
App version: 0.7-alpha-6c08d882d3
@BenHenning
Copy link
Member

BenHenning commented May 18, 2022 •
edited
Loading

This is a known issue that comes from two separate problems working in concert: (1) no remote profiles (which makes resetting reliably difficult), and (2) automatic app backups via the Android system making the reinstall flow not actually fix the problem.

You can work around the issue by going into app system settings and clearing data (which also forces the app to reset). This is, unfortunately, a very severe way of fixing the problem as it wipes all progress and profiles on the device. If that's not acceptable in your particular case (i.e. for testing), let me know and we can try a more direct route to fix it.

The above workaround is definitely not user-friendly, and it's far too punishing to the user since their progress isn't remotely synced. We have a project in the works to find a better medium-term solution until actual remote profiles are added. I'm not sure if there's a tracking issue for this yet, so it's nice to have this issue to track it.

Edit: Also, this is likely a hard blocker for the beta release since it's likely for users to hit this, and it more or less breaks the app for them in a way that they are unlikely to be able to figure out a workaround for on their own.

@BenHenning BenHenning added this to the Beta milestone May 18, 2022
@BenHenning BenHenning self-assigned this May 18, 2022
@Broppia Broppia added issue_type_bug Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). labels May 31, 2022
@BenHenning BenHenning modified the milestones: Beta, Beta MR1 Jun 11, 2022
@BenHenning BenHenning mentioned this issue Jul 3, 2022
Merged
6 tasks
BenHenning added a commit that referenced this issue Sep 7, 2022
@BenHenning
Fix #4366, #3611, #4323: Add app data reset flow to facilitate being …
ca2660f 
…able to reset the admin pin (#4418)

## Explanation
Fixes #4366
Fixes #3611
Fixes #4323

This PR introduces a data reset flow for cases when the user fails to remember their administrator pin. Since there's no remote profile support currently, the only option is to clear all profiles on the device. This is done using a two-step dialog since the action is permanent (at least for now--in the future we could consider making a local backup that could be restored, but that could become pretty complicated).

While this isn't a great solution, it's better than not having an option at all since users can currently get permanently stuck (see #3611). While this doesn't directly fix #3611, it mitigates it by providing a proper in-app means of resetting app data.

#4323 seems unrelated, but resetting the app required routing back to SplashActivity which means this PR needed to introduce a robustness mechanism to not set the app locale unless it wasn't already initialized (which bypasses the bug mentioned by that issue).

Mechanically, the deletion process involves:
- Deleting all profiles on the device
- Updating the in-memory cache (which causes a few UI glitches)
- "Restarting" the app by ending the activity and routing back to SplashActivity

This replaces the existing "forgot PIN" flow for admins, and it technically does not reset non-profile data (such as the device installation ID, onboarding status, analytics/crash events, and some device-wide preferences).

## Essential Checklist
- [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
- [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation.
- [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
This PR is using the app's existing alert dialog theme, so it's not particularly interesting to show landscape/tablet screenshots as the UI isn't fundamentally different. The same is the case for special internationalization or accessibility concerns.

In terms of a demonstration of the new flow, see the following video:

https://user-images.githubusercontent.com/12983742/186572278-d0238e62-d013-419a-9c49-afe97cd10a5d.mp4

#4567 is tracking introducing tests, and the PR addressing it for these changes will include demonstrations of changed Espresso tests.

Commits:

* Add app data reset flow for resetting admin pin.

* Fix broken test.

* Update text & fix data reset issue.
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenHenning BenHenning

Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.9 Release Blockers (Beta "Early Acc...
4 participants
@seanlip @BenHenning @KolliAnitha @Broppia