Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Copy" function misaligned in the UI #4281

Closed
srushtirk opened this issue Mar 31, 2022 · 5 comments
Closed

"Copy" function misaligned in the UI #4281

srushtirk opened this issue Mar 31, 2022 · 5 comments
Assignees
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@srushtirk
Copy link

Describe the bug
Copy function next to the device ID is misaligned in the UI

To Reproduce
Steps to reproduce the behavior:

  1. Go to Administrator Controls
  2. Click on Profile Learner IDs & Sync Status
  3. See error next to Device ID

Expected behavior
"Copy" icon and text should be horizontally aligned after the Device ID. This possibly means reducing the font for "Device ID"

Demonstration
image

Environment

  • Device/emulator being used: Pixel 5
  • Android or SDK version (e.g. Android 5 or SDK 21): Android 12
  • App version (you can get this through system app settings or via the admin controls menu in-app): 0.7-alpha-d1b2827517

Additional context
Add any other context about the problem here.

@srushtirk srushtirk added this to the Alpha MR4 milestone Mar 31, 2022
@yash37158
Copy link

can I work on this issue?

@yash37158
Copy link

yash37158 commented Apr 2, 2022

I can't see profile learners' id and sync status options in administrative control, can you please guide me through this issue? @srushtirk

@BenHenning
Copy link
Member

Apologies @yash37158 this issue corresponds to UI functionality that's not yet checked in. Assigning to myself to avoid further confusion.

@BenHenning BenHenning self-assigned this Apr 12, 2022
@BenHenning
Copy link
Member

BenHenning commented May 2, 2022

This problem is fairly easy to reproduce by maximizing device zoom. It actually gets exacerbated by:

  • Very long profile names (completely cuts off the copy button)
  • Display + font zoom (which completely cuts off the installation ID copy button)

Note that the above was tested on a Nexus 5X which has a smaller screen to start with, so that exact behavior may not be observed on larger screen densities.

BenHenning added a commit that referenced this issue May 3, 2022
Plus, some other miscellaneous cleanups & fixes (particularly around
highlighting items in admin controls on tablets).
@BenHenning
Copy link
Member

For searching context, this issue was found in 0.7-alpha (MR4).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

No branches or pull requests

3 participants