Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audio button touch target is too small #382

Closed
BenHenning opened this issue Nov 16, 2019 · 1 comment
Closed

Audio button touch target is too small #382

BenHenning opened this issue Nov 16, 2019 · 1 comment
Assignees
@jamesxu0 @nikitamarysolomanpvt
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

The exploration player audio button's touch target is 24dp, but should be 48dp per accessibility & usability recommendations.
@BenHenning BenHenning added Priority: Essential This work item must be completed for its milestone. Status: Not started labels Nov 16, 2019
@nikitamarysolomanpvt nikitamarysolomanpvt self-assigned this Nov 25, 2019
Merged
10 tasks
nikitamarysolomanpvt added a commit that referenced this issue Nov 26, 2019
@nikitamarysolomanpvt
Fix part #17,#382: Hi fi topic audio bar (#467)
b5bc32b 
As per the verbal discussion the audio bar was not playable in android API 19 and lowfi issue.

* thumb seekbar

* shadow to audio bar

* audio bar width as per screen width

* audio bar width as per screen width

* play and pause icons size
@nikitamarysolomanpvt
Copy link
Contributor

Closed via #467

@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesxu0 jamesxu0

@nikitamarysolomanpvt nikitamarysolomanpvt

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BenHenning @jamesxu0 @nikitamarysolomanpvt