Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11y] Enable A11y Tests: StateFragmentTest + ExplorationActivityTest #3251

Closed
rt4914 opened this issue May 25, 2021 · 0 comments · Fixed by #3390
Closed

[A11y] Enable A11y Tests: StateFragmentTest + ExplorationActivityTest #3251

rt4914 opened this issue May 25, 2021 · 0 comments · Fixed by #3390
Assignees
@rt4914
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented May 25, 2021

Multiple tests are failing on #3246 with following error:
Screenshot 2021-05-25 at 9 35 33 PM

Content TextView Size Error

Because content_text_view can have clickable links therefore the min height of the TextView should be atleast 48dp
Screenshot 2021-05-25 at 9 38 07 PM

Feedback TextView Size Error

Because feedback_text_view can have clickable links therefore the min height of the TextView should be atleast 48dp
No failure screenshot as we need to fix the above error first.

Drag&Drop Error

Tracking in #2323

##NumericInputInteraction
There are A11y errors because one state with NumericInputInteraction does not contain any hint.

NOTE: There can be more A11y errors once we fix these errors.
@rt4914 rt4914 self-assigned this May 25, 2021
@rt4914 rt4914 added Priority: Essential This work item must be completed for its milestone. Type: Improvement and removed Status: Not started labels May 25, 2021
@rt4914 rt4914 added this to the Beta milestone May 25, 2021
This was referenced May 25, 2021
Merged
Closed
Merged
@rt4914 rt4914 changed the title [A11y] Enable A11y Tests: StateFragmentTest [A11y] Enable A11y Tests: StateFragmentTest + ExplorationActivityTest Jun 9, 2021
BenHenning pushed a commit that referenced this issue Jun 22, 2021
@rt4914
Fixes part of #3251: Added hint to numeric input (#3253)
6a7e596 
* Added hint to numeric input

* Removed content description

* Added test

Co-authored-by: Rajat Talesra <[email protected]>
This was referenced Jun 29, 2021
Merged
Merged
anandwana001 pushed a commit that referenced this issue Jun 29, 2021
@rt4914
Fix #3251: A11y checks pass for ExplorationActivityTest (#3390)
a918b1c 
* Fixes A11y checks for ExplorationActivityTest

* Nit fix

* Fix tests

Co-authored-by: Rajat Talesra <[email protected]>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3251: A11y checks pass for ExplorationActivityTest oppia/oppia-android
3 participants
@rt4914 @seanlip @BenHenning