Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spdk: add vfio-user #6

Merged
merged 1 commit into from
Jan 9, 2023
Merged

spdk: add vfio-user #6

merged 1 commit into from
Jan 9, 2023

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Oct 21, 2022

For some reason when adding --with-vfio-user
RPM build is not working any more
So adding ugly hack LDFLAGS=" "
and --without-shared

Signed-off-by: Boris Glimcher [email protected]

@artek-koltun
Copy link
Contributor

Hi @glimchb, you can try to add LDFLAGS=" " env var like we did here. This "dirty hack" might help to resolve your problem with rpm builds.

@glimchb
Copy link
Member Author

glimchb commented Dec 14, 2022

Hi @glimchb, you can try to add LDFLAGS=" " env var like we did here. This "dirty hack" might help to resolve your problem with rpm builds.

thanks for the tip, trying...

@glimchb glimchb force-pushed the vfio branch 2 times, most recently from 6dc416d to 687f5dd Compare January 8, 2023 22:42
@artek-koltun
Copy link
Contributor

Hi @glimchb, you can try to add LDFLAGS=" " env var like we did here. This "dirty hack" might help to resolve your problem with rpm builds.

thanks for the tip, trying...

Hi Boris, again
I see that it didn't help, but it looks like if we remove --with-shared then it will work. Also I can try to take care of it if you don't mind

@glimchb
Copy link
Member Author

glimchb commented Jan 9, 2023

Hi @glimchb, you can try to add LDFLAGS=" " env var like we did here. This "dirty hack" might help to resolve your problem with rpm builds.

thanks for the tip, trying...

Hi Boris, again I see that it didn't help, but it looks like if we remove --with-shared then it will work. Also I can try to take care of it if you don't mind

@artek-koltun Hey. The compilation was successful

...
Checking for unpackaged file(s): /usr/lib/rpm/check-files /root/rpmbuild/buildroot/spdk-v22.09-1.x86_64
Wrote: /root/rpmbuild/srcrpm/spdk-v22.09-1.src.rpm
Wrote: /root/rpmbuild/rpm/x86_64/spdk-devel-v22.09-1.x86_64.rpm
Wrote: /root/rpmbuild/rpm/x86_64/spdk-v22.09-1.x86_64.rpm
Wrote: /root/rpmbuild/rpm/x86_64/spdk-dpdk-libs-v22.09-1.x86_64.rpm
Wrote: /root/rpmbuild/rpm/x86_64/spdk-libs-v22.09-1.x86_64.rpm

but RPM install didn't work

 dnf install -y /root/rpmbuild/rpm/x86_64/*.rpm
...
  - nothing provides libvfio-user.so.0()(64bit) needed by spdk-libs-v22.09-1.x86_64

looks like dependency error in spec file maybe ?

pushing new change... let's see now...

@glimchb glimchb marked this pull request as ready for review January 9, 2023 18:08
@glimchb glimchb requested a review from a team as a code owner January 9, 2023 18:08
For some reason when adding --with-vfio-user
RPM build is not working any more
So adding ugly hack LDFLAGS=" "
and --without-shared

Signed-off-by: Boris Glimcher <[email protected]>
@glimchb glimchb merged commit 8475a25 into main Jan 9, 2023
@glimchb glimchb deleted the vfio branch January 9, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants