spdk: middle: add AccelCryptoKeyDestroy #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #145 +/- ##
==========================================
- Coverage 49.27% 48.72% -0.56%
==========================================
Files 4 4
Lines 1236 1250 +14
==========================================
Hits 609 609
- Misses 608 622 +14
Partials 19 19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
fails on spdk/spdk#2904 |
Fixes opiproject#143 Signed-off-by: Boris Glimcher <[email protected]>
seroyer
reviewed
Feb 10, 2023
| @@ -99,6 +99,7 @@ func (s *Server) DeleteEncryptedVolume(ctx context.Context, in *pb.DeleteEncrypt | |||
| // UpdateEncryptedVolume updates an encrypted volume | |||
| func (s *Server) UpdateEncryptedVolume(ctx context.Context, in *pb.UpdateEncryptedVolumeRequest) (*pb.EncryptedVolume, error) { | |||
| log.Printf("UpdateEncryptedVolume: Received from client: %v", in) | |||
| // first delete old bdev | |||
There was a problem hiding this comment.
Hmm, codecov doesn't seem very smart to flag a comment line
| @@ -121,7 +136,7 @@ func (s *Server) UpdateEncryptedVolume(ctx context.Context, in *pb.UpdateEncrypt | |||
| } | |||
| params2 := AccelCryptoKeyCreateParams{ | |||
| Cipher: r.FindStringSubmatch(in.EncryptedVolume.Cipher.String())[1], | |||
| Name: "super_key2", | |||
| Name: "super_key", | |||
| Key: string(in.EncryptedVolume.Key), | |||
| Key2: strings.Repeat("b", len(in.EncryptedVolume.Key)), | |||
There was a problem hiding this comment.
Should this be "a"'s repeated?
There was a problem hiding this comment.
wanted to show a change from a to b since this is update command
seroyer
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143
Signed-off-by: Boris Glimcher [email protected]