-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update github.com/opiproject/opi-api digest to ca2c25b #20
Update github.com/opiproject/opi-api digest to ca2c25b #20
Conversation
Codecov Report
@@ Coverage Diff @@
## main #20 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 547 579 +32
=====================================
- Misses 547 579 +32
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Boris Glimcher <[email protected]>
Signed-off-by: Boris Glimcher <[email protected]>
b9cd7bd
to
6f18655
Compare
Technically, a user could do this sequence of steps:
In this case, it needs to go add all the namespaces to the controller inside the CreateNvmeController call. |
This is why I thought we should keep the API calls separate and mandate CTRL-id when you create NS and if not provided, it does the for-loop... |
A namespace can't be in just a single controller, so the namespace having a controller id isn't sufficient. Image this scenario:
Where some time passes between step 3 and 4. That's a valid thing to do and it needs to be handled. Now the namespace should be in two controllers. That's the reason I removed controller_id from the namespace object - it doesn't model the relationship correctly. |
I would imagine : |
So now you have two namespace resources representing the same physical object? |
This PR contains the following updates:
ffe4aad
->ca2c25b
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.