[storage][front-end] Remove xxxDeleteResponse messages #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following Google AIP-135 - Standard methods: Delete Related to opiproject#174 Signed-off-by: Boris Glimcher <[email protected]>
Signed-off-by: Boris Glimcher <[email protected]>
glimchb
requested review from
jainvipin,
benlwalker,
llabordehpe,
mkalderon,
orendu and
PWAlessi
glimchb
added a commit
to glimchb/opi-spdk-bridge
that referenced
this pull request
Nov 2, 2022
see opiproject/opi-api#181 Signed-off-by: Boris Glimcher <[email protected]>
glimchb
added a commit
to glimchb/opi-spdk-bridge
that referenced
this pull request
Nov 2, 2022
see opiproject/opi-api#181 Signed-off-by: Boris Glimcher <[email protected]>
glimchb
added
the
Merge Candidate
mestery
approved these changes
Nov 2, 2022
PWAlessi
approved these changes
Nov 2, 2022
|
|
||
| // Front End (host-facing) APIs. | ||
|
|
||
| // NVMe/PCIe emulation | ||
|
|
||
| service NVMeSubsystemService { | ||
| rpc NVMeSubsystemCreate (NVMeSubsystemCreateRequest) returns (NVMeSubsystem) {} | ||
| rpc NVMeSubsystemDelete (NVMeSubsystemDeleteRequest) returns (NVMeSubsystemDeleteResponse) {} | ||
| rpc NVMeSubsystemDelete (NVMeSubsystemDeleteRequest) returns (google.protobuf.Empty) {} |
There was a problem hiding this comment.
👍 better to return empty than an empty message
benlwalker
approved these changes
Nov 2, 2022
glimchb
added a commit
to glimchb/opi-spdk-bridge
that referenced
this pull request
Nov 2, 2022
see opiproject/opi-api#181 Signed-off-by: Boris Glimcher <[email protected]>
glimchb
added a commit
to opiproject/opi-spdk-bridge
that referenced
this pull request
Nov 2, 2022
see opiproject/opi-api#181 Signed-off-by: Boris Glimcher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following Google AIP-135 - Standard methods: Delete
Related to #174