This repository has been archived by the owner on Aug 12, 2024. It is now read-only.
Add a CRD Upgrade Safety preflight check to the BundleDeployment controller
#873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-merge-robot
added
the
needs-rebase
joelanford
reviewed
May 1, 2024
joelanford
reviewed
May 1, 2024
joelanford
reviewed
May 1, 2024
everettraven
force-pushed
the
feature/preflight
branch
from
db14475 to
97fd561
Compare
openshift-merge-robot
removed
the
needs-rebase
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #873 +/- ##
==========================================
- Coverage 15.06% 14.55% -0.52%
==========================================
Files 40 41 +1
Lines 2443 2529 +86
==========================================
Hits 368 368
- Misses 2018 2104 +86
Partials 57 57 ☔ View full report in Codecov by Sentry. |
openshift-merge-robot
added
the
needs-rebase
everettraven
force-pushed
the
feature/preflight
branch
from
3d4d5b5 to
70a5e18
Compare
openshift-merge-robot
removed
the
needs-rebase
everettraven
force-pushed
the
feature/preflight
branch
2 times, most recently
from
21cd9e6 to
3d643ee
Compare
everettraven
changed the title
BundleDeployment controller
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
grokspawn
reviewed
May 13, 2024
grokspawn
reviewed
May 13, 2024
openshift-merge-robot
added
the
needs-rebase
everettraven
force-pushed
the
feature/preflight
branch
from
043a1ae to
a01ed84
Compare
openshift-merge-robot
removed
the
needs-rebase
| @@ -101,6 +101,12 @@ func WithActionClientGetter(acg helmclient.ActionClientGetter) Option { | |||
| } | |||
| } | |||
|
|
|||
| func WithPreflights(preflights ...Preflight) Option { | |||
There was a problem hiding this comment.
Nit: Is this required and present by default for now? If so, it would be nice to add a validation for this in validateConfig func, just to avoid programmer's error since we are calling preflight.Install directly.
There was a problem hiding this comment.
It is not required. If there are no preflight checks defined neither preflight.Install() nor preflight.Upgrade() should be called.
openshift-merge-robot
added
the
needs-rebase
everettraven
force-pushed
the
feature/preflight
branch
from
a01ed84 to
1d2aab8
Compare
openshift-merge-robot
removed
the
needs-rebase
everettraven
force-pushed
the
feature/preflight
branch
2 times, most recently
from
1117d74 to
595b5c2
Compare
joelanford
reviewed
May 22, 2024
joelanford
reviewed
May 22, 2024
joelanford
reviewed
May 22, 2024
Signed-off-by: everettraven <[email protected]>
everettraven
force-pushed
the
feature/preflight
branch
from
595b5c2 to
e2ba479
Compare
joelanford
approved these changes
May 22, 2024
Merged
via the queue into
operator-framework:main
with commit May 23, 2024
96043d4
8 of 10 checks passed
This was referenced May 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
preflights/crdupgradesafetypackage containing the logic for a CRD Upgrade Safety preflight checkBundleDeploymentcontroller to be able to be configured with preflight checks and runs them if they are configured