-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1.24.x] OCPBUGS-1666: Expose flag to enable/disable PodSecurity #6080
Merged
jmrodri
merged 7 commits into
operator-framework:v1.24.x
from
openshift-cherrypick-robot:cherry-pick-6062-to-v1.24.x
Oct 13, 2022
Merged
[v1.24.x] OCPBUGS-1666: Expose flag to enable/disable PodSecurity #6080
jmrodri
merged 7 commits into
operator-framework:v1.24.x
from
openshift-cherrypick-robot:cherry-pick-6062-to-v1.24.x
Oct 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added --security-context-config flag to enable seccompprofile. It defaults to enabled to support k8s 1.25. You can disable it with --security-context-config=legacy Signed-off-by: jesus m. rodriguez <[email protected]>
* Ignoring error from Set call in test * Update .cncf maintainers * Update run bundle(-upgrade) CLI docs Signed-off-by: jesus m. rodriguez <[email protected]>
Signed-off-by: jesus m. rodriguez <[email protected]>
Signed-off-by: jesus m. rodriguez <[email protected]>
Signed-off-by: jesus m. rodriguez <[email protected]>
Signed-off-by: jesus m. rodriguez <[email protected]>
This was being duplicated because we had it in the text but were not setting the value to a default value. Once we set the value to the default cobra realized this and would output "(default: restricted)". So removing the manually entered text fixes the duplicate. Signed-off-by: jesus m. rodriguez <[email protected]>
2 tasks
/lgtm |
jmrodri
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
everettraven
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #6062
/assign jmrodri