Bugfix: Generate just the extra FBC for run bundle-upgrade #5891
Conversation
Signed-off-by: rashmigottipati <[email protected]>
Signed-off-by: rashmigottipati <[email protected]>
Signed-off-by: rashmigottipati <[email protected]>
rashmigottipati
requested review from
VenkatRamaraju
and removed request for
marc-obrien
| @@ -0,0 +1,25 @@ | |||
| # entries is a list of entries to include in | |||
There was a problem hiding this comment.
For run bundle, when an index image is being passed, we are now generating just the extra FBC needed in the ConfigMap and mounting that as a volume in the registry pod. Sorun bundle-upgrade` needs to be updated to generate just the extra FBC instead of creating the entire declarative config and appending bundle contents to it which will cause duplicate package/channel/bundle errors and fail.
So, we create another FBC index to add the upgraded bundle. Is that the solution?
There was a problem hiding this comment.
@camilamacedo86 We don't create another FBC index to add the bundle. We add the just the extra bundle contents to a ConfigMap under the directory (which is /configs) that hosts the index already, so we don't have to append to index's contents again.
| # release notes and/or the migration guide | ||
| entries: | ||
| - description: > | ||
| For run bundle-upgrade, generate just the extra FBC of the bundle instead of rendering the entire index and appending bundle contents to it. |
There was a problem hiding this comment.
How can we test this one to check that the PR fix?
What is the image/data used to do the test?
There was a problem hiding this comment.
These are the images I used for testing:
run bundle with bundle quay.io/olmqe/upgradeindex-bundle:v0.1 and index image quay.io/olmqe/nginxolm-operator-index:v1.
And run bundle-upgrade with quay.io/olmqe/upgradeindex-bundle:v0.2
|
/cherry-pick v1.22.x |
|
@everettraven: new pull request created: #5917 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of the change:
Partial fix to #5870
Motivation for the change:
For run bundle, when an index image is being passed, we are now generating just the extra FBC needed in the
ConfigMapand mounting that as a volume in the registry pod. Sorun bundle-upgradeneeds to be updated to generate just the extra FBC instead of creating the entire declarative config and appending bundle contents to it which will cause duplicate package/channel/bundle errors and fail.Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs