(ansible/v1, helm/v1): deprecate the flag since APIs is not longer offered from k8s 1.22 and this flag is deprecated for Golang #5815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilamacedo86
requested review from
varshaprasad96 and
fabianvf
and removed request for
jmrodri
…fered from k8s 1.22 and this flag is deprecated for Golang Signed-off-by: Camila Macedo <[email protected]>
everettraven
previously requested changes
May 31, 2022
| entries: | ||
| - description: > | ||
| For Ansible/Helm based-operators (ansible/v1, helm/v1), deprecate the flag `crd-version` since | ||
| `v1beta1` APIs is not longer offered from k8s 1.22 and this flag is deprecated for Golang. |
There was a problem hiding this comment.
Do we need to back port this to the SDK release which supports k8s 1.22?
There was a problem hiding this comment.
It is not a bug fix so if we not be able to backport that is 100% fine.
However, I think that would be cool if we are able to do that
Co-authored-by: Bryce Palmer <[email protected]>
camilamacedo86
requested review from
varshaprasad96,
laxmikantbpandhare and
everettraven
camilamacedo86
dismissed
everettraven’s stale review
all suggestions were addressed
VenkatRamaraju
pushed a commit
to VenkatRamaraju/operator-sdk
that referenced
this pull request
Jun 9, 2022
…fered from k8s 1.22 and this flag is deprecated for Golang (operator-framework#5815) * (ansible/v1, helm/v1): deprecate the flag since APIs is not longer offered from k8s 1.22 and this flag is deprecated for Golang Signed-off-by: Camila Macedo <[email protected]> * Update internal/plugins/util/message.go Co-authored-by: Bryce Palmer <[email protected]> Co-authored-by: Bryce Palmer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
deprecate the flag since APIs is not longer offered from k8s 1.22 and this flag is deprecated for Golang
NOTE: Users should no longer be using this option since if they scaffold projects with v1beta1 it will no longer work on Kubernetes versions >= 1.22. By using v1 for CRDs they can create projects which can work since Kubernetes 1.16