-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansible-operator controller: Add an option to watch annotations #5611
ansible-operator controller: Add an option to watch annotations #5611
Conversation
a7c2c8f
to
2dd713e
Compare
4d5435c
to
3914496
Compare
3914496
to
eb770b8
Compare
Hello, any news regarding this PR ? Do you expect something more ? |
Sorry this one slipped through the cracks. I've reopened the issue and marked it to be retriaged (by removing the milestone). On Monday, this will be discussed in our community meeting, everyone is always welcome especially if you want to advocate for an issue. This request seems reasonable to me, but I'd like some other eyes too. Once the issue is retriaged, I'll do a review here. @gaelgatelement Thanks for your patience-- double thanks for the PR! |
Since we all get so many notifications, if something isn't getting attention, some light nagging is acceptable and encouraged. The community meeting is probably the most bang for the buck, but you can also ping us on slack. |
Hello ! I'm coming back to know if you had time to discuss about this PR ? Thanks ! |
eb770b8
to
d3e41f2
Compare
d3e41f2
to
7cc7170
Compare
Hello, I rebased again. I'd love to be able to join you on slack if this is necessary to talk about this during the community meeting. But I'll need an invite, as my company does not have a slack account. Can you send it to me at gaelg at element.io ? Thanks. |
7cc7170
to
df71120
Compare
@gaelgatelement if you're ever interested in joining the community meetings, you can find the links here: https://github.com/operator-framework/community |
We to watch annotations changes to trigger a reconciliation. Fixes operator-framework#4245 Signed-off-by: Gaël Goinvic <[email protected]>
This feature allows the ansible operator to trigger reconciliations on annotations changes on watched resources Signed-off-by: Gaël Goinvic <[email protected]>
Add annotations to foo-sample and check that the role is triggered by displaying it in the logs. Signed-off-by: Gaël Goinvic <[email protected]>
df71120
to
7538495
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
We'd want to watch annotations changes to trigger a reconciliation.
Notably fixes this closed issue, even if this is actually not our use-case. #4245
Description of the change:
This change adds an option
watchAnnotationsChanges
to ansible watches. When this option is used on a watch, any annotation change will trigger a reconciliation.Motivation for the change:
In our case, we need this feature to be able to trigger the reconciliation of a resource when an external resource (a secret or a configmap for example) gets updated. We update the hash of the external resource in the annotation, which forces a reconciliation of the dependent resource.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs