Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm reconcile period: fixed docs + align with Ansible #5599

Merged

Conversation

VenkatRamaraju
Copy link
Contributor

Signed-off-by: Venkat Ramaraju [email protected]

Description of the change:
Moved the reconcile-period docs for the custom resource annotations to the right place.
Moved around some of the implementation from #5585 to align with Ansible.

Motivation for the change:
Align Helm and Ansible for this feature.

@VenkatRamaraju VenkatRamaraju force-pushed the reconcile-period-helm branch from f042a39 to 9be200a Compare March 14, 2022 16:49
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2022
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@VenkatRamaraju VenkatRamaraju merged commit f5e15be into operator-framework:master Mar 16, 2022
prary pushed a commit to prary/operator-sdk that referenced this pull request Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants