Scorecard optional Config.yaml Service Account selection #5245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ish Shah <[email protected]>
added 2 commits
September 28, 2021 08:32
Signed-off-by: Ish Shah <[email protected]>
Signed-off-by: Ish Shah <[email protected]>
theishshah
changed the title
|
v0.10.6 has been released in operator-framework/api allowing this PR to proceed. |
jmrodri
requested changes
Sep 28, 2021
Comment on lines
201
to
206
| runnerSA := "" | ||
| if o.Config.ServiceAccount != "" { | ||
| runnerSA = o.Config.ServiceAccount | ||
| } else { | ||
| runnerSA = c.serviceAccount | ||
| } |
There was a problem hiding this comment.
Since you're already initializing it, might as well set it to the default value
Suggested change
| runnerSA := "" | |
| if o.Config.ServiceAccount != "" { | |
| runnerSA = o.Config.ServiceAccount | |
| } else { | |
| runnerSA = c.serviceAccount | |
| } | |
| runnerSA := c.serviceAccount | |
| if o.Config.ServiceAccount != "" { | |
| runnerSA = o.Config.ServiceAccount | |
| } |
added 2 commits
September 28, 2021 08:54
Signed-off-by: Ish Shah <[email protected]>
Signed-off-by: Ish Shah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables selecting the service account for the scorecard using the config.yaml in addition to the existing method of changing it at runtime in the CLI.
This blocked on an API release which should occur shortly.