Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade OPM version used #5099

Merged
merged 5 commits into from
Dec 21, 2021
Merged

Conversation

twasyl
Copy link
Contributor

@twasyl twasyl commented Jul 29, 2021

Description of the change:
The generated Makefile uses a more recent version of opm

Motivation for the change:
On OSX, using the version v1.15.1 of opm leads to the following error:

Error: Binary was compiled with 'CGO_ENABLED=0', go-sqlite3 requires cgo to work.

when doing a make catalog-build. Using the latest version of opm (v1.19.1 at the time of this PR) solves the issue.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@openshift-ci openshift-ci bot requested review from fabianvf and theishshah July 29, 2021 20:44
@estroz
Copy link
Member

estroz commented Aug 4, 2021

@twasyl unfortunately until operator-framework/operator-registry#710 is released this can't merge, since all versions after 1.15.1 do not support multiple linux arches. It will be merged soon though, so we can get this in then. In the meantime, can you add a DCO to your commit message? Thanks!

@twasyl twasyl force-pushed the upgrade-opm-version branch from 6091e98 to 737d91b Compare August 5, 2021 08:46
@twasyl
Copy link
Contributor Author

twasyl commented Aug 5, 2021

@twasyl unfortunately until operator-framework/operator-registry#710 is released this can't merge, since all versions after 1.15.1 do not support multiple linux arches. It will be merged soon though, so we can get this in then. In the meantime, can you add a DCO to your commit message? Thanks!

@estroz Sure, it's not an urgent PR as the version used can be changed in the generated Makefile.

@camilamacedo86
Copy link
Contributor

camilamacedo86 commented Aug 28, 2021

@twasyl

It is only missing add changelog entry to generate the release notes.
And we can indeed use: v1.18.0 WDYT?

Otherwise, lgtm

@twasyl
Copy link
Contributor Author

twasyl commented Aug 30, 2021

Hi @camilamacedo86 - Thanks for the review. I've updated the OPM version used to v1.18.0 and updated changelog/fragments/00-template.yaml directly but I'm not sure it's the right way of doing it. Maybe I should rather create a new file somewhere? Please let me know.

@joelanford
Copy link
Member

@twasyl The 00-template.yaml file is not intended to be changed. Please copy it to a new file in that same folder. Filename doesn't matter as long as it ends with .yaml.

@twasyl
Copy link
Contributor Author

twasyl commented Aug 31, 2021

@joelanford - Thanks for the explanation. I reverted the change to the original file and created a new one for the release notes.

@rashmigottipati
Copy link
Member

operator-framework/operator-registry#710 is merged. Is this PR still blocked?

Also, DCO has to be added to the commit message.

@twasyl twasyl force-pushed the upgrade-opm-version branch from 0a04c8d to 55d86cb Compare September 3, 2021 13:17
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 12, 2021
@twasyl twasyl force-pushed the upgrade-opm-version branch from 55d86cb to 0e0d88b Compare September 24, 2021 12:54
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 24, 2021
twasyl and others added 5 commits November 10, 2021 20:23
Signed-off-by: Thierry Wasylczenko <[email protected]>
Signed-off-by: Thierry Wasylczenko <[email protected]>
Signed-off-by: Thierry Wasylczenko <[email protected]>
Signed-off-by: Thierry Wasylczenko <[email protected]>
@twasyl twasyl force-pushed the upgrade-opm-version branch from 0e0d88b to 7ff32f7 Compare November 10, 2021 19:30
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2021
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jmrodri jmrodri merged commit dad3e83 into operator-framework:master Dec 21, 2021
@twasyl twasyl deleted the upgrade-opm-version branch January 3, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants