-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade OPM version used #5099
Upgrade OPM version used #5099
Conversation
@twasyl unfortunately until operator-framework/operator-registry#710 is released this can't merge, since all versions after 1.15.1 do not support multiple linux arches. It will be merged soon though, so we can get this in then. In the meantime, can you add a DCO to your commit message? Thanks! |
6091e98
to
737d91b
Compare
@estroz Sure, it's not an urgent PR as the version used can be changed in the generated |
It is only missing add changelog entry to generate the release notes. Otherwise, lgtm |
Hi @camilamacedo86 - Thanks for the review. I've updated the OPM version used to |
@twasyl The |
@joelanford - Thanks for the explanation. I reverted the change to the original file and created a new one for the release notes. |
operator-framework/operator-registry#710 is merged. Is this PR still blocked? Also, DCO has to be added to the commit message. |
0a04c8d
to
55d86cb
Compare
55d86cb
to
0e0d88b
Compare
Signed-off-by: Thierry Wasylczenko <[email protected]>
Signed-off-by: Thierry Wasylczenko <[email protected]>
Signed-off-by: Thierry Wasylczenko <[email protected]>
Signed-off-by: Thierry Wasylczenko <[email protected]>
Signed-off-by: Thierry Wasylczenko <[email protected]>
0e0d88b
to
7ff32f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Description of the change:
The generated
Makefile
uses a more recent version ofopm
Motivation for the change:
On OSX, using the version
v1.15.1
ofopm
leads to the following error:when doing a
make catalog-build
. Using the latest version ofopm
(v1.19.1
at the time of this PR) solves the issue.Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs