Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images/ansible-operator/Dockerfile: pin cryptography python package #4523

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #4510

/assign estroz

…o version that does not require the rust compiler to set up

Signed-off-by: Eric Stroczynski <[email protected]>
@estroz estroz changed the title [master] [v1.3.x] images/ansible-operator/Dockerfile: pin cryptography python package images/ansible-operator/Dockerfile: pin cryptography python package Feb 13, 2021
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2021
@@ -17,6 +17,7 @@ RUN yum clean all && rm -rf /var/cache/yum/* \
&& yum -y update \
&& yum install -y libffi-devel openssl-devel python38-devel gcc python38-pip python38-setuptools \
&& pip3 install --no-cache-dir \
cryptography==3.3.1 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we the fragment over this change? I could not find it?
So, wdyt about to do a follow-up pr with that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change isn’t user-facing, see #4510 (comment).

@estroz
Copy link
Member

estroz commented Feb 13, 2021

Closing in favor of #4494

@estroz estroz closed this Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants