Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pkg/helm to internal/helm #3537

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Move pkg/helm to internal/helm #3537

merged 2 commits into from
Jul 27, 2020

Conversation

hasbro17
Copy link
Contributor

@hasbro17 hasbro17 commented Jul 25, 2020 •
edited by joelanford
Loading

Description of the change:
Move pkg/helm to internal/helm.

Motivation for the change:

Remove public APIs in prep for v1.0.0

varshaprasad96
varshaprasad96 approved these changes Jul 25, 2020
View reviewed changes
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2020
joelanford
joelanford approved these changes Jul 25, 2020
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I would prefer to keep the helm/internal/types structure, even within the existing root internal directory because it prevents those types from being imported outside the helm package tree.

Otherwise
/lgtm

@joelanford joelanford force-pushed the mv-pkg-helm-internal branch from 9f74c4c to d124a98 Compare July 27, 2020 13:41
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2020
@jmrodri
Copy link
Member

jmrodri commented Jul 27, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2020
jmrodri
jmrodri approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@jmrodri jmrodri merged commit 8b95fdc into operator-framework:master Jul 27, 2020
@joelanford joelanford mentioned this pull request Jul 27, 2020
Closed
92 tasks
@hasbro17 hasbro17 deleted the mv-pkg-helm-internal branch July 27, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varshaprasad96 varshaprasad96 varshaprasad96 approved these changes

@joelanford joelanford joelanford approved these changes

@jmrodri jmrodri jmrodri approved these changes

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

@estroz estroz Awaiting requested review from estroz

Assignees

@jmrodri jmrodri

@joelanford joelanford

@varshaprasad96 varshaprasad96

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hasbro17 @jmrodri @joelanford @varshaprasad96 @openshift-ci-robot