-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace instrumented handler with the one from operator-lib #3523
Merged
jmrodri
merged 1 commit into
operator-framework:master
from
jmrodri:use-operator-lib-metrics
Jul 24, 2020
Merged
replace instrumented handler with the one from operator-lib #3523
jmrodri
merged 1 commit into
operator-framework:master
from
jmrodri:use-operator-lib-metrics
Jul 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92 tasks
2 tasks
estroz
reviewed
Jul 24, 2020
estroz
reviewed
Jul 24, 2020
estroz
approved these changes
Jul 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
joelanford
approved these changes
Jul 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
jmrodri
force-pushed
the
use-operator-lib-metrics
branch
from
July 24, 2020 15:56
53240c4
to
aaf8bff
Compare
New changes are detected. LGTM label has been removed. |
jmrodri
force-pushed
the
use-operator-lib-metrics
branch
from
July 24, 2020 17:49
aaf8bff
to
7ddaccd
Compare
openshift-ci-robot
added
the
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
label
Jul 24, 2020
jmrodri
force-pushed
the
use-operator-lib-metrics
branch
from
July 24, 2020 18:09
7ddaccd
to
e98aba1
Compare
openshift-ci-robot
removed
the
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
label
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Replace the instrumented handler with the one from operator-lib
Motivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs