feat(configmap): add configmap loader #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to support the older catalog format, which stores data in a configmap
alecmerdler
reviewed
Oct 18, 2018
|
|
||
| var _ SQLPopulator = &ConfigMapLoader{} | ||
|
|
||
| func NewSQLLoaderForConfigMap(store registry.Load, configMap v1.ConfigMap) *ConfigMapLoader { |
There was a problem hiding this comment.
Wouldn't it be better to remove the intermediate ConfigMap and just consume a directory of manifests? Since the ConfigMap will probably be too large to kubectl create anyway?
There was a problem hiding this comment.
That's a decision we can make on the OLM side (what to do with the configmap after we have them converted here). I was thinking that it would make sense to continue to support the configmaps as a low barrier to entry; not really convinced they're that much easier though.
philbrookes
added a commit
to philbrookes/operator-registry
that referenced
this pull request
Apr 24, 2019
remove .idea dir and ignore it
kevinrizza
pushed a commit
to kevinrizza/operator-registry
that referenced
this pull request
Oct 29, 2019
…layers read all bundle image layers
rashmigottipati
added a commit
to rashmigottipati/operator-registry
that referenced
this pull request
Jul 25, 2023
Signed-off-by: Rashmi Gottipati <[email protected]>
openshift-merge-robot
pushed a commit
that referenced
this pull request
Jul 25, 2023
… to a file-based catalog (#1127) * Documentation on how to add a plain bundle to a file-based catalog Signed-off-by: Rashmi Gottipati <[email protected]> * Address review feedback Signed-off-by: Rashmi Gottipati <[email protected]> * Clarify regular bundle to be of registry+v1 format Signed-off-by: Rashmi Gottipati <[email protected]> * Address review feedback #1 Signed-off-by: Rashmi Gottipati <[email protected]> * Address review feedback #2 Signed-off-by: Rashmi Gottipati <[email protected]> * Address review feedback #3 Signed-off-by: Rashmi Gottipati <[email protected]> * Add an example for the desired channel name and link to OLM best practices for channel naming conventions Signed-off-by: Rashmi Gottipati <[email protected]> --------- Signed-off-by: Rashmi Gottipati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support the older catalog format, which stores data in a configmap.
OLM will use this to interact with configmaps and catalog images using the same interface.