Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default goal since bingo disrupts it #1447

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

grokspawn
Copy link
Contributor

Description of the change:
set a default goal of all for the Makefile

Motivation for the change:
since 7a1b8ec the all goal is no longer the first (and therefore default-by-default) goal. This explicitly makes it the default target again.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.47%. Comparing base (a9fd06a) to head (742f67e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1447   +/-   ##
=======================================
  Coverage   48.47%   48.47%           
=======================================
  Files         136      136           
  Lines       12814    12814           
=======================================
  Hits         6212     6212           
  Misses       5561     5561           
  Partials     1041     1041           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

openshift-ci bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, grokspawn, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [grokspawn,joelanford]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@joelanford joelanford added this pull request to the merge queue Sep 10, 2024
Merged via the queue into operator-framework:master with commit 40014c2 Sep 10, 2024
11 of 12 checks passed
@grokspawn grokspawn deleted the default-goal branch September 11, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants