-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 update unit test gha to test against the k8s version of client-go #3272
Merged
perdasilva
merged 4 commits into
operator-framework:master
from
perdasilva:perdasilva/fix-unit-gha
May 23, 2024
Merged
🌱 update unit test gha to test against the k8s version of client-go #3272
perdasilva
merged 4 commits into
operator-framework:master
from
perdasilva:perdasilva/fix-unit-gha
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ba79e2
to
81b7dc3
Compare
Signed-off-by: Per Goncalves da Silva <[email protected]>
cdfe57d
to
234c358
Compare
Signed-off-by: Per Goncalves da Silva <[email protected]>
234c358
to
11a0414
Compare
m1kola
previously approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
New changes are detected. LGTM label has been removed. |
m1kola
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Merged
via the queue into
operator-framework:master
with commit May 23, 2024
f9485ff
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
The unit test job was testing against an old/pinned version of the kube libs. This PR updates the gha to take the kube version from the go-client lib and simplifies the makefile and unit test gha a bit
This PR also fixes a couple of flakes I've found along the way:
Motivation for the change:
unit test stage failing for latest kube version
Architectural changes:
Testing remarks:
Reviewer Checklist
/doc
[FLAKE]
are truly flaky and have an issue