Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 update unit test gha to test against the k8s version of client-go #3272

Merged

Conversation

perdasilva
Copy link
Collaborator

@perdasilva perdasilva commented May 23, 2024

Description of the change:
The unit test job was testing against an old/pinned version of the kube libs. This PR updates the gha to take the kube version from the go-client lib and simplifies the makefile and unit test gha a bit

This PR also fixes a couple of flakes I've found along the way:

  • in the installplan e2e, a csv update step would flake due to update conflicts
  • in the subscription e2e a consistently block would execute before the resource could be updated

Motivation for the change:
unit test stage failing for latest kube version

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot requested review from dtfranz and gallettilance May 23, 2024 07:15
@perdasilva perdasilva force-pushed the perdasilva/fix-unit-gha branch 9 times, most recently from 4ba79e2 to 81b7dc3 Compare May 23, 2024 09:13
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva force-pushed the perdasilva/fix-unit-gha branch 2 times, most recently from cdfe57d to 234c358 Compare May 23, 2024 09:21
@perdasilva perdasilva force-pushed the perdasilva/fix-unit-gha branch from 234c358 to 11a0414 Compare May 23, 2024 09:23
m1kola
m1kola previously approved these changes May 23, 2024
Copy link
Member

@m1kola m1kola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2024
@perdasilva perdasilva enabled auto-merge May 23, 2024 10:49
@perdasilva perdasilva added this pull request to the merge queue May 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2024
@perdasilva perdasilva added this pull request to the merge queue May 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2024
Per Goncalves da Silva added 2 commits May 23, 2024 15:07
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 23, 2024
Copy link

openshift-ci bot commented May 23, 2024

New changes are detected. LGTM label has been removed.

@perdasilva perdasilva added the lgtm Indicates that a PR is ready to be merged. label May 23, 2024
@perdasilva perdasilva enabled auto-merge May 23, 2024 13:42
@perdasilva perdasilva disabled auto-merge May 23, 2024 13:42
Copy link
Member

@m1kola m1kola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@perdasilva perdasilva added this pull request to the merge queue May 23, 2024
Merged via the queue into operator-framework:master with commit f9485ff May 23, 2024
13 checks passed
@perdasilva perdasilva deleted the perdasilva/fix-unit-gha branch May 23, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants