Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-fix: refactor test package names 'packageA' and 'packageB' #3260

Merged
merged 1 commit into from
May 16, 2024
Merged

test-fix: refactor test package names 'packageA' and 'packageB' #3260

merged 1 commit into from
May 16, 2024

Conversation

perdasilva
Copy link
Collaborator

@perdasilva perdasilva commented May 16, 2024 •
edited
Loading

Description of the change:
Makes some of the test package names DNS-1123 label compliant: packageA -> test-package packageB -> another-package

Motivation for the change:
Recent changes to the operator-registry have started to validate package names to ensure they are DNS-1123 label compliant. This was breaking some of our e2e tests.

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot requested review from benluddy and dtfranz May 16, 2024 12:04
@perdasilva perdasilva changed the title bugfix: refactor test package names 'packageA' and 'packageB' because… [WIP] refactor test package names 'packageA' and 'packageB' because… May 16, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2024
@perdasilva perdasilva force-pushed the perdasilva/bugfix branch from 3e31d58 to 443f837 Compare May 16, 2024 12:42
@perdasilva perdasilva changed the title [WIP] refactor test package names 'packageA' and 'packageB' because… test-fix: refactor test package names 'packageA' and 'packageB' May 16, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2024
@perdasilva perdasilva force-pushed the perdasilva/bugfix branch 2 times, most recently from 7a83e3f to a53f133 Compare May 16, 2024 13:33
bugfix: refactor test package names 'packageA' and 'packageB' because…
988335b 
… they break naming conventions

Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva force-pushed the perdasilva/bugfix branch from a53f133 to 988335b Compare May 16, 2024 14:20
@kevinrizza kevinrizza added this pull request to the merge queue May 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 16, 2024
@perdasilva perdasilva added this pull request to the merge queue May 16, 2024
Merged via the queue into operator-framework:master with commit 3e0230e May 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinrizza kevinrizza kevinrizza approved these changes

@benluddy benluddy Awaiting requested review from benluddy

@dtfranz dtfranz Awaiting requested review from dtfranz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@perdasilva @kevinrizza