Fix crd data loss e2e test #3173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
approved
perdasilva
force-pushed
the
perdasilva/crd-e2e-dataloss-flake-fix
branch
from
cc5d1d1 to
f6d5239
Compare
perdasilva
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
blocking merge as there might be a better way to solve this |
Signed-off-by: Per Goncalves da Silva <[email protected]>
perdasilva
dismissed stale reviews from tmshort and ankitathomas
via
c679200
perdasilva
force-pushed
the
perdasilva/crd-e2e-dataloss-flake-fix
branch
from
f6d5239 to
c679200
Compare
perdasilva
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
tmshort
approved these changes
Feb 12, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitathomas, perdasilva, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
operator-framework:master
with commit Feb 12, 2024
85d9de2
15 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes CRD e2e flake "blocks a CRD upgrade that could cause data loss".
Cause
The test steps involve installing a bundle, then upgrading it to a bundle with a bad crd. The install plan will retry for 60 seconds before reaching a failed state.
Fix
Applying the operatorframework.io/bundle-unpack-timeout to the OG in the test namespace to reduce the retry timeout to 5 seconds (instead of 60) leading to faster failed states
Fixes #2638