-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switches from BundleLookupFailed
defined in OLM to the one defined in the .../api
package
#2959
Switches from BundleLookupFailed
defined in OLM to the one defined in the .../api
package
#2959
Conversation
Skipping CI for Draft Pull Request. |
c48e609
to
86aa8e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - nice! thanks for not letting this drop!!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitathomas, m1kola, perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Mikalai Radchuk <[email protected]>
86aa8e4
to
8ca28d8
Compare
New changes are detected. LGTM label has been removed. |
Description of the change:
BundleLookupFailed
is currently defined in the OLM codebase, but the latest release of thegithub.aaakk.us.kg/operator-framework/api
package containsBundleLookupFailed
definition (see the relevant PR).This PR updates OLM to switch to the constant defined in
github.com/operator-framework/api
Motivation for the change:
Cleanup of the old TODO.
Architectural changes:
Refactoring
Testing remarks:
Existing tests should cover changes.
Reviewer Checklist
/doc
[FLAKE]
are truly flaky and have an issue