Allow E2E to skip multiple tests #2892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
awgreene
force-pushed
the
split-skip-string
branch
from
ac297db to
663c7dc
Compare
Problem: There are instances where a user may wish to skip multiple e2e tests. Solution: Allow users to specify multple tests to skip in the e2e suite by setting multiple test names separated by the semicolon (;) symbol.` Signed-off-by: Alexander Greene <[email protected]>
awgreene
force-pushed
the
split-skip-string
branch
from
663c7dc to
ea790fc
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
awgreene
added a commit
to awgreene/operator-lifecycle-manager
that referenced
this pull request
Nov 12, 2022
This reverts commit 6cfd86c.
awgreene
added a commit
to awgreene/operator-lifecycle-manager
that referenced
this pull request
Nov 12, 2022
This reverts commit 6cfd86c. Signed-off-by: Alexander Greene <[email protected]>
awgreene
added a commit
to awgreene/operator-lifecycle-manager
that referenced
this pull request
Nov 12, 2022
This reverts commit 6cfd86c, which is not necessary because the ginkgo run --skip flag supports regex. Signed-off-by: Alexander Greene <[email protected]>
openshift-merge-robot
pushed a commit
that referenced
this pull request
Nov 14, 2022
This reverts commit 6cfd86c, which is not necessary because the ginkgo run --skip flag supports regex. Signed-off-by: Alexander Greene <[email protected]> Signed-off-by: Alexander Greene <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: There are instances where a user may wish to skip multiple e2e tests.
Solution: Allow users to specify multple tests to skip in the e2e suite by setting multiple test names separated by the semicolon (;) symbol.`
Signed-off-by: Alexander Greene [email protected]