Bump kind dependency #2888
Merged
Bump kind dependency #2888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
approved
awgreene
commented
Nov 4, 2022
test/e2e/installplan_e2e_test.go
Outdated
Comment on lines
126
to
125
| Expect(policyv1beta1.AddToScheme(scheme)).To(Succeed()) | ||
| Expect(deprecatedv1.AddToScheme(scheme)).To(Succeed()) | ||
| { | ||
| var b bytes.Buffer | ||
| Expect(k8sjson.NewSerializer(k8sjson.DefaultMetaFactory, scheme, scheme, false).Encode(&pdb, &b)).To(Succeed()) | ||
| Expect(k8sjson.NewSerializer(k8sjson.DefaultMetaFactory, scheme, scheme, false).Encode(&deprecated, &b)).To(Succeed()) | ||
| manifest = b.String() |
There was a problem hiding this comment.
If we can get rid of this scheme thing, we won't need to import https://github.com/awgreene/deprecated-crd
awgreene
commented
Nov 4, 2022
test/e2e/installplan_e2e_test.go
Outdated
Comment on lines
111
to
156
| deprecatedCRD := &apiextensionsv1.CustomResourceDefinition{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: "deprecateds.operators.io.operator-framework", | ||
| }, | ||
| Spec: apiextensionsv1.CustomResourceDefinitionSpec{ | ||
| Names: apiextensionsv1.CustomResourceDefinitionNames{ | ||
| Plural: "deprecateds", | ||
| ListKind: "DeprecatedList", | ||
| Singular: "deprecated", | ||
| Kind: "Deprecated", | ||
| }, | ||
| Scope: "Namespaced", | ||
| Group: "operators.io.operator-framework", | ||
| Versions: []apiextensionsv1.CustomResourceDefinitionVersion{ | ||
| { | ||
| Name: "v1", | ||
| Served: true, | ||
| Storage: true, | ||
| Deprecated: true, | ||
| Schema: &apiextensionsv1.CustomResourceValidation{ | ||
| OpenAPIV3Schema: &apiextensionsv1.JSONSchemaProps{ | ||
| Type: "object", | ||
| Properties: map[string]apiextensionsv1.JSONSchemaProps{ | ||
| "spec": { | ||
| Type: "object", | ||
| Description: "Spec of a test object.", | ||
| Properties: map[string]apiextensionsv1.JSONSchemaProps{ | ||
| "foo": { | ||
| Type: "string", | ||
| }, | ||
| }, | ||
| }, | ||
| "status": { | ||
| Type: "object", | ||
| Description: "Spec of a test object.", | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| Status: apiextensionsv1.CustomResourceDefinitionStatus{ | ||
| StoredVersions: []string{"v1"}, | ||
| }, | ||
| } |
There was a problem hiding this comment.
Could move this to a test file for readability's sake.
awgreene
force-pushed
the
bump-kind-dependency
branch
from
7b014ad to
6cfc050
Compare
Signed-off-by: Alexander Greene <[email protected]>
awgreene
force-pushed
the
bump-kind-dependency
branch
2 times, most recently
from
73ba4e7 to
eea9d12
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
awgreene
force-pushed
the
bump-kind-dependency
branch
4 times, most recently
from
a16facb to
05fcc63
Compare
timflannagan
reviewed
Nov 7, 2022
Signed-off-by: Alexander Greene <[email protected]>
awgreene
force-pushed
the
bump-kind-dependency
branch
from
05fcc63 to
28f77ff
Compare
grokspawn
approved these changes
Nov 7, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, grokspawn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
1 similar comment
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change:
Architectural changes:
Testing remarks:
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issue