-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OWNERS file #2882
Update OWNERS file #2882
Conversation
/lgtm |
We need to follow our new process described in the contributor ladder. https://github.com/operator-framework/community/blob/master/contributor-ladder.md#reviewer We need 2 "Approvers" to act as sponsors agreeing that we have "demonstrated an in-depth knowledge of the specific area" and before this merges, all OLM Approvers should be notified and given the chance to (privately) express concerns. By opening this PR, Alex I think we can count Alex as Sponsor #1. Anyone else willing to be sponsor #2? For @dfranz and I, we just need to commit to "being responsible for that specific area" that we have demonstrated expertise. This is deliberately vague in the governing document to give significant leeway to the Approvers. It doesn't need to be as formal as what follows, but: "I @asmacdo do commit to reviewing pull requests for OLM." I'll approve once we have a 2nd sponsor and the Approvers have discussed and approved (or at least discussed and do not mind). |
/approve |
c308d2e
to
a2f4857
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, kevinrizza, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
This commit adds dtfranz and asmacdo to the list of reviewers. Signed-off-by: Alexander Greene <[email protected]>
a2f4857
to
4d4d341
Compare
/lgtm |
This commit adds dtfranz and asmacdo to the list of reviewers.
Signed-off-by: Alexander Greene [email protected]