Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OWNERS file #2882

Merged

Conversation

awgreene
Copy link
Member

@awgreene awgreene commented Nov 1, 2022

This commit adds dtfranz and asmacdo to the list of reviewers.

Signed-off-by: Alexander Greene [email protected]

@awgreene
Copy link
Member Author

awgreene commented Nov 1, 2022

Please review @dtfranz and @asmacdo

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2022
@dtfranz
Copy link
Contributor

dtfranz commented Nov 1, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2022
@asmacdo
Copy link
Member

asmacdo commented Nov 1, 2022

We need to follow our new process described in the contributor ladder.

https://github.com/operator-framework/community/blob/master/contributor-ladder.md#reviewer

We need 2 "Approvers" to act as sponsors agreeing that we have "demonstrated an in-depth knowledge of the specific area" and before this merges, all OLM Approvers should be notified and given the chance to (privately) express concerns.

By opening this PR, Alex I think we can count Alex as Sponsor #1. Anyone else willing to be sponsor #2?

For @dfranz and I, we just need to commit to "being responsible for that specific area" that we have demonstrated expertise. This is deliberately vague in the governing document to give significant leeway to the Approvers.

It doesn't need to be as formal as what follows, but: "I @asmacdo do commit to reviewing pull requests for OLM."

I'll approve once we have a 2nd sponsor and the Approvers have discussed and approved (or at least discussed and do not mind).

@kevinrizza
Copy link
Member

/approve

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, kevinrizza, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [awgreene,kevinrizza,timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@timflannagan
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2022
This commit adds dtfranz and asmacdo to the list of reviewers.

Signed-off-by: Alexander Greene <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2022
@timflannagan
Copy link
Member

/lgtm
/uncc

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2022
@openshift-merge-robot openshift-merge-robot merged commit 8da6522 into operator-framework:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants