Bug 1907792: Change the OperatorUpgradeable condition to Upgradeable #1911
Conversation
openshift-ci-robot
added
bugzilla/severity-medium
|
@dinhxuanvu: This pull request references Bugzilla bug 1907792, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
@dinhxuanvu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
dinhxuanvu
force-pushed
the
upgradeable-type
branch
from
7fb25b7 to
83c9ca9
Compare
dinhxuanvu
changed the title
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
| By("This test proves that an operator can upgrade successfully when" + | ||
| "OperatorUpgrade condition is set in OperatorCondition CR. Plus, an operator" + | ||
| "Upgrade condition rype is set in OperatorCondition CR. Plus, an operator" + |
There was a problem hiding this comment.
| "Upgrade condition rype is set in OperatorCondition CR. Plus, an operator" + | |
| "Upgrade condition type is set in OperatorCondition CR. Plus, an operator" + |
dinhxuanvu
force-pushed
the
upgradeable-type
branch
from
83c9ca9 to
1dc799e
Compare
|
/lgtm |
The original design intends to use the name "Upgradeable for operator condition. Signed-off-by: Vu Dinh <[email protected]>
awgreene
force-pushed
the
upgradeable-type
branch
from
1dc799e to
d6d7fb5
Compare
|
/retest |
|
@dinhxuanvu: This pull request references Bugzilla bug 1907792, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
I think we got lucky that we didn't cut a release -- in both upstream and OCP -- when this was an option. If we had and we were being strict about it, I think we would have needed to continue support for "OperatorUpgradeable" until we could formally deprecate it.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
@dinhxuanvu: All pull requests linked via external trackers have merged: Bugzilla bug 1907792 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The original design intends to use the name
Upgradeableonly.Signed-off-by: Vu Dinh [email protected]
Description of the change:
Gate operator upgrade on the "Upgradeable" OperatorCondition status type instead of "OperatorUpgradeable".
Motivation for the change:
The OperatorConditions enhancement indicates that OLM gates upgrades on a status condition type of "Upgradeable", not "OperatorUpgradeable".
Reviewer Checklist
/docs