Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support configmap creation from the bundle #1434

Merged
merged 1 commit into from
Apr 15, 2020
Merged

feat: support configmap creation from the bundle #1434

merged 1 commit into from
Apr 15, 2020

Conversation

exdx
Copy link
Member

@exdx exdx commented Apr 8, 2020

Description of the change:
Follow up on operator-framework/operator-registry#256.

Now that configmap objects are supported in bundles as first-class citizens, OLM needs to be able to create config maps from the bundle and lifecycle them along with the CSV. This PR enables the catalog operator to work with configmap types.

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@exdx exdx requested review from njhale and kevinrizza April 8, 2020 19:20
ecordell
ecordell approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, exdx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2020
@exdx
Copy link
Member Author

exdx commented Apr 9, 2020

/retest

@exdx
Copy link
Member Author

exdx commented Apr 9, 2020

@ecordell would prefer to keep this PR configmap only and follow up with an additional PR for secret types

@exdx
Copy link
Member Author

exdx commented Apr 9, 2020

/retest

1 similar comment
@exdx
Copy link
Member Author

exdx commented Apr 9, 2020

/retest

njhale
njhale reviewed Apr 12, 2020
View reviewed changes
Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice job! I left a few thoughts that I'd like to discuss before this goes through though:

pkg/controller/operators/catalog/operator.go Show resolved Hide resolved
pkg/controller/operators/catalog/operator.go Outdated Show resolved Hide resolved
pkg/controller/operators/catalog/step_ensurer.go Outdated Show resolved Hide resolved
pkg/controller/operators/catalog/step_ensurer.go Show resolved Hide resolved
pkg/lib/operatorclient/configmap.go Show resolved Hide resolved
@njhale
Copy link
Member

njhale commented Apr 12, 2020

/retest

1 similar comment
@njhale
Copy link
Member

njhale commented Apr 13, 2020

/retest

@exdx
Copy link
Member Author

exdx commented Apr 13, 2020

@njhale thanks for the review. In the interest of CI time would you be ok LGTMing and I can update the text error fields ("service" -> "configmap") in my follow up PR for additional OLM types (secrets, PSP, etc)? As well as the patch strategy if we want to change that.

Your other points regarding code duplication and the dynamic client make a lot of sense but I'm not sure I have the time to address those this week

@njhale
Copy link
Member

njhale commented Apr 13, 2020

Let's move forward with this as is -- we can follow up on some of these comments later.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@exdx
Copy link
Member Author

exdx commented Apr 13, 2020

/test e2e-aws-olm

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@exdx
Copy link
Member Author

exdx commented Apr 14, 2020

/retest

@exdx exdx force-pushed the feat/support-configmaps branch from 503887d to e517d03 Compare April 14, 2020 21:50
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2020
@njhale
Copy link
Member

njhale commented Apr 14, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0efd123 into operator-framework:master Apr 15, 2020
@adellape adellape mentioned this pull request Aug 28, 2020
Merged
@pliurh pliurh mentioned this pull request Jun 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njhale njhale njhale left review comments

@ecordell ecordell ecordell approved these changes

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

Assignees

@njhale njhale

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@exdx @openshift-ci-robot @njhale @openshift-bot @ecordell @openshift-merge-robot