Skip to content

Commit

Permalink
OCPBUGS-8993: add namespace label to InstallPlanStepAppliedWithWarnin…
Browse files Browse the repository at this point in the history
…gs (#3012)

The alerting consistency guide [1] requires the following:

`Alerts SHOULD include a namespace label indicating the alert's source.`

This change updates the expression of InstallPlanStepAppliedWithWarnings
to aggregate the result by namespace.

[1] https://github.com/openshift/enhancements/blob/master/enhancements/monitoring/alerting-consistency.md

Signed-off-by: Simon Pasquier <[email protected]>
  • Loading branch information
simonpasquier authored Aug 23, 2023
1 parent 12437b3 commit 2976198
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion deploy/chart/templates/0000_90_olm_01-prometheus-rule.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ spec:
- name: olm.installplan.rules
rules:
- alert: InstallPlanStepAppliedWithWarnings
expr: sum(increase(installplan_warnings_total[5m])) > 0
expr: sum by(namespace) (increase(installplan_warnings_total[5m])) > 0
labels:
severity: warning
annotations:
Expand Down

0 comments on commit 2976198

Please sign in to comment.