Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 bump catalogd to v0.11.0 #578

Merged
merged 1 commit into from
Jan 17, 2024
Merged

🌱 bump catalogd to v0.11.0 #578

merged 1 commit into from
Jan 17, 2024

Conversation

everettraven
Copy link
Contributor

@everettraven everettraven commented Jan 12, 2024 •
edited
Loading

Description

  • Bumps catalogd --> v0.11.0
  • Bumps kind to v0.20.0 and ensures we are using a 1.28 node image for testing

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@everettraven everettraven requested a review from a team as a code owner January 12, 2024 21:44
@codecov Codecov
Copy link

codecov bot commented Jan 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (58c5455) 84.33% compared to head (2d1e78b) 84.33%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #578   +/-   ##
=======================================
  Coverage   84.33%   84.33%           
=======================================
  Files          20       20           
  Lines         932      932           
=======================================
  Hits          786      786           
  Misses        102      102           
  Partials       44       44
Flag Coverage Δ
e2e 60.19% <ø> (ø)
unit 80.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Jan 15, 2024
Closed
Merged
joelanford
joelanford reviewed Jan 15, 2024
View reviewed changes
Makefile Outdated
@@ -25,6 +25,7 @@ export ARTIFACT_PATH ?=

OPERATOR_CONTROLLER_NAMESPACE ?= operator-controller-system
KIND_CLUSTER_NAME ?= operator-controller
KIND_CLUSTER_IMAGE ?= kindest/node:v1.28.0@sha256:b7a4cad12c197af3ba43202d3efe03246b3f0793f162afb40a33c923952d5b31
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why hardcode this and not take the default from the version of kind we're using?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest version of kind has a default node image based on 1.27.3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kubernetes-sigs/kind/releases/tag/v0.20.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to use ENVTEST_VERSION to derive a kind image ref?

Setting a hardcoded digest strikes me as something that will rot, and we'll forget about.

Alternately, maybe we just accept that kind's default might be off by a release or two?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2d1e78b ?

grokspawn
grokspawn previously approved these changes Jan 17, 2024
View reviewed changes
@everettraven everettraven added this pull request to the merge queue Jan 17, 2024
@grokspawn grokspawn removed this pull request from the merge queue due to a manual request Jan 17, 2024
@grokspawn
Copy link
Contributor

/hold to give @joelanford a chance to reply to comments.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2024
@everettraven
bump catalogd to v0.11.0
4231844 
Signed-off-by: everettraven <[email protected]>
@joelanford joelanford enabled auto-merge January 17, 2024 15:48
@joelanford joelanford added this pull request to the merge queue Jan 17, 2024
Merged via the queue into operator-framework:main with commit 2c85388 Jan 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

@grokspawn grokspawn grokspawn left review comments

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@everettraven @grokspawn @joelanford