Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Removes leftovers from Ginkgo #561

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Dec 1, 2023

Description

We no longer use Ginkgo (see #189), but we still have some leftovers of it. This PR removes the remaining bits.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Mikalai Radchuk <[email protected]>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6cb7029) 83.93% compared to head (9a4b6a3) 83.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #561   +/-   ##
=======================================
  Coverage   83.93%   83.93%           
=======================================
  Files          20       20           
  Lines         809      809           
=======================================
  Hits          679      679           
  Misses         90       90           
  Partials       40       40           
Flag Coverage Δ
e2e 63.78% <ø> (ø)
unit 78.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola m1kola marked this pull request as ready for review December 1, 2023 12:02
@m1kola m1kola requested a review from a team as a code owner December 1, 2023 12:02
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2023
@m1kola m1kola added this pull request to the merge queue Dec 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 1, 2023
@m1kola m1kola added this pull request to the merge queue Dec 1, 2023
Merged via the queue into operator-framework:main with commit 1b4fa3e Dec 1, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants