🌱 Update installed package unit tests #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
m1kola
force-pushed
the
installed_package_test_cmp
branch
2 times, most recently
from
bbf0693 to
800d435
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #524 +/- ##
==========================================
- Coverage 84.72% 84.50% -0.22%
==========================================
Files 23 23
Lines 910 910
==========================================
- Hits 771 769 -2
- Misses 95 96 +1
- Partials 44 45 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
m1kola
force-pushed
the
installed_package_test_cmp
branch
from
800d435 to
dcfc7ad
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
awgreene
reviewed
Nov 10, 2023
This commit does two things. First: It splits the `TestMakeInstalledPackageVariables` test into two tests: * One for when `ForceSemverUpgradeConstraints` feature gate enabled (semver) * One for when `ForceSemverUpgradeConstraints` feature gate disabled (legacy semantics) Both tests are now table-style tests. This is done mainly so that we can maintain test data for different semantics separately (e.g. no need to maintain channel entires for semver tests). Second: Adds extra coverage for disabled state of the `ForceSemverUpgradeConstraints` feature gate. Previously we were not covering some cases for this state of the gate. Example of such case is when `UpgradeConstraintPolicy` field on `Operator` is set to `Ignore`. Signed-off-by: Mikalai Radchuk <[email protected]>
m1kola
force-pushed
the
installed_package_test_cmp
branch
from
dcfc7ad to
75a6f8a
Compare
awgreene
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit does two things.
First: It splits the
TestMakeInstalledPackageVariablestest into two tests:ForceSemverUpgradeConstraintsfeature gate enabled (semver)ForceSemverUpgradeConstraintsfeature gate disabled (legacy semantics)Both tests are now table-style tests.
This is done mainly so that we can maintain test data for different semantics separately (e.g. no need to maintain channel entires for semver tests).
Second: Adds extra coverage for disabled state of the
ForceSemverUpgradeConstraintsfeature gate. Previously we were not covering some cases for this state of the gate. Example of such case is whenUpgradeConstraintPolicyfield onOperatoris set toIgnore.Reviewer Checklist