Part 2: Reduce number of variable sources. Bundle variables. #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
This was referenced Oct 31, 2023
m1kola
force-pushed
the
shrink_variable_sources_p2
branch
from
0c38e67 to
4f9d453
Compare
4 tasks
m1kola
changed the title
m1kola
force-pushed
the
shrink_variable_sources_p2
branch
from
4f9d453 to
e4a1377
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #498 +/- ##
==========================================
+ Coverage 84.11% 84.41% +0.30%
==========================================
Files 23 23
Lines 875 892 +17
==========================================
+ Hits 736 753 +17
Misses 95 95
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
m1kola
commented
Nov 1, 2023
m1kola
force-pushed
the
shrink_variable_sources_p2
branch
5 times, most recently
from
8d2811d to
c9a1ea5
Compare
joelanford
reviewed
Nov 2, 2023
joelanford
reviewed
Nov 2, 2023
joelanford
reviewed
Nov 2, 2023
joelanford
reviewed
Nov 2, 2023
joelanford
reviewed
Nov 2, 2023
joelanford
reviewed
Nov 2, 2023
m1kola
commented
Nov 2, 2023
m1kola
force-pushed
the
shrink_variable_sources_p2
branch
3 times, most recently
from
05bd2d7 to
237206a
Compare
m1kola
force-pushed
the
shrink_variable_sources_p2
branch
from
237206a to
d92550d
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@joelanford please take another look. I believe I addressed all your feedback. |
m1kola
commented
Nov 3, 2023
4 tasks
m1kola
force-pushed
the
shrink_variable_sources_p2
branch
from
d92550d to
3070b48
Compare
openshift-merge-robot
added
the
needs-rebase
|
Moveing back to draft for now becuase it needs a bit more work after #508 + address feedback. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Signed-off-by: Mikalai Radchuk <[email protected]>
Signed-off-by: Mikalai Radchuk <[email protected]>
m1kola
force-pushed
the
shrink_variable_sources_p2
branch
from
3070b48 to
8ecced7
Compare
openshift-merge-robot
removed
the
needs-rebase
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@stevekuznetsov @joelanford rebased on top of #508 + addressed feedback. Please take another look |
stevekuznetsov
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spliting #460 into smaller chunks. Related to #437
In this part I extract code related to creating bundle variables from
BundlesAndDepsVariableSourceinto a separate function.BundlesAndDepsVariableSourcewill be removed later in #501Reviewer Checklist