Refactor controllers test setup & teardown for reusability between Ginkgo and standard Go tests #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #473 +/- ##
==========================================
+ Coverage 83.41% 83.64% +0.23%
==========================================
Files 23 23
Lines 862 862
==========================================
+ Hits 719 721 +2
+ Misses 97 96 -1
+ Partials 46 45 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
m1kola
force-pushed
the
controllers_setup-teardown
branch
from
4fbab63 to
8fe25b4
Compare
m1kola
changed the title
This will enable both Ginkgo and standard Go tests to use the same setup & teardown. Signed-off-by: Mikalai Radchuk <[email protected]>
m1kola
force-pushed
the
controllers_setup-teardown
branch
from
8fe25b4 to
0ae42f3
Compare
m1kola
commented
Oct 20, 2023
| cl client.Client | ||
| sch *runtime.Scheme |
There was a problem hiding this comment.
I removed cfg and testEnv from here. They were defined on the package level so that both BeforeSuite and AfterSuite could access them. Now that we do setup and teardown in single TestMain function - they can be function scoped.
Comment on lines
-82
to
-89
| var operators operatorsv1alpha1.OperatorList | ||
| var bundleDeployments rukpakv1alpha1.BundleDeploymentList | ||
|
|
||
| Expect(cl.List(context.Background(), &operators)).To(Succeed()) | ||
| Expect(cl.List(context.Background(), &bundleDeployments)).To(Succeed()) | ||
|
|
||
| Expect(namesFromList(&operators)).To(BeEmpty(), "operators left in the cluster") | ||
| Expect(namesFromList(&bundleDeployments)).To(BeEmpty(), "bundle deployments left in the cluster") |
There was a problem hiding this comment.
I droped this bit. I do not see much value in failing after tests.
There was a problem hiding this comment.
I think it was to ensure everything is cleaned up before stopping the running envtest process, but if envtest exits just fine without this cleanup I think its OK to remove
4 tasks
everettraven
approved these changes
Oct 20, 2023
LalatenduMohanty
pushed a commit
to LalatenduMohanty/operator-controller
that referenced
this pull request
Dec 19, 2024
`check-cluster` is already a dependency of the `install` targt, which is a dependency of `e2e`. It does not need to be a dependency of `test-e2e` which _just_ runs the tests without any setup. Signed-off-by: Todd Short <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will enable both Ginkgo and standard Go tests to use the same setup & teardown.
This will help to get rid of some of the setup boilerplate in #469.
Reviewer Checklist